From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.167.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795162272; b=bAIGMYRmBjwczv1EYBkmifi3wdbj/l4/+5XgH9a5YuNmzDxAo4Ialol0xcQBZxI/0g/A /knBKDix0B+vsg/mqtmi+u/eOx9ctZeJ5KJ3qS8dMCr1YG/fDcodMmroLuu6epOy49u2C xXTgddhHxle4fXt46SEq0hVbkedLmkPwZ35ALuNjwtpV6PraUO4go+Ewi7uMhcAXLFkFD b7XDIAZ/0bXTi25UcIXVFcOx1kE3lMXZ3RP9gT2xuL1z894v+QGDyXm++drDkeHU7M6Kp GWcnLf6Vy+yt/pF3keZkJgbuMbHGJaDLDouOpZyzs4G0YdBHLB+8OypnPTERfNkUmXw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795162272; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=KesKeUvHiMdS1LmxeerRsnDhtdf500zX8ZdToOP0rAE=; b=PhIU5tHzMVxpfXBtHWUcdvpjNkt0gjcEvJ7h5SmAqzZvCagqqNZK7xPw+oVmbziNeNiF hSeQyqYpnHDAqC2vms9zR7nXyZr9AZOzlvvZW4YcFj01quDgIt5mi/Qrv4owuto0Q3M7b 08B+CNlC22dDxsxJFQiO7rTvY6n2Uf2PKXPM1TbhPAkfnPpvXqD1bIrF8y6TKQhbL14Fd Rj1iw6t6ARWCIdSlaTWwVrGhpAv355fGbWnIbx+8+skklA5/YMNIIyuh6quMn9YnebaeH I3SPXlTmypXEX2reSprDjITwXJAhP1NtH0Z4Tycs7LAzm/u5j5gDCPdO+YXCicUVOLw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=JPuSwB2N; arc=none smtp.remote-ip=209.85.167.54 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8EBF606A330 for ; Fri, 20 Nov 2026 08:11:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B8EBF606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=JPuSwB2N Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5c14f3dab66so557885e87.0 for ; Fri, 20 Nov 2026 00:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795162270; x=1795767070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KesKeUvHiMdS1LmxeerRsnDhtdf500zX8ZdToOP0rAE=; b=JPuSwB2Nih7gGboyvYZGHEFVyAAT5jR0tAzI1/z6nXBTiepqdhbG0OMaGaisVK5Eii 9H14U2OncF7/V49Iy41oGgRN5M37pZB2xRV+DSLvb6bmVryWdyEtm3Dz2U7f1LllFoD9 /SuGzgxYeSLTQ6msRDYzWBaG9p/iJ5RIizUFRTovJlZMehV0omqGULs1viP2clmYiLZJ /OzWgwIyFBilROvRKpdDfx7rZhbhbcBt9p+MhwBwur/clab8cVKN7WmpqUgOIlDaE9tD kZpftuO04kEw64nuT3eUl4f4HMMaSVQZdOFblvCtyB3SBuvClKcCHAQoQRxE3ZbsyErx LBAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795162270; x=1795767070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=KesKeUvHiMdS1LmxeerRsnDhtdf500zX8ZdToOP0rAE=; b=ycScjkKp3z6flnVifM1a1A/XKRawwcBeKqkSoWybXUSGiVz7PcekNrh7/TTwEa83Lu JfdyN/raTD0BDpnYomCTIs4Dhy+sRCnTplHRBG4unOgwSyDOqx+REY1i9+oXab5mIVVW lzMBlx8yqoUC3w3QrrB3zNqS9Cw9Db9mz7Stu4PTwrxinAsTfui9WXv8Pkw28jvzoCH6 2inlWF0ormzddvTcPWG3izm3ufxkhFrpqFO04BPokK+zxYdf+HApI2QRbAvIyHcNbRcW Jfkd6w8pznMdZrgn35kixVQz87mysgDpUf7snCKLaH6v2erP73yNB9oYFKh9KyttwLHF mdCg== X-Forwarded-Encrypted: i=1; AL+hErGN3GP9XvMnGOktZBel9lKG5hIrnPIDobqf9RwWKER3RD2Ie1RhEz13beVK9Xt5PcN5RYqRGpze42hX27g=@vger.kernel.org X-Gm-Message-State: APuU4Z8Bfhj7N22fZu52NCXsbGMoHjxDTNBYNHXTHfbSxLGHS5mNcI3U vCE4GstA1rBC461OxAXSSnonCMgjc9/J/lzbhpY5l3iywNbtl+uShC4J X-Gm-Gg: AZFdTZdUYSVT7GGLkj30LW3MfuQuKyX6fl6a/eE/qt7Jd7VxxHkpajU6BoS4Lov7o7U A2AY5dGTkYqWZW/3joEtyn91cdNPT1UI4jyWZzk+JmARmvxFUNU+Z6njTwpF+kxtIl+cagekrfI pwWkEKCcH7R2PkYT8SODp0XiagYzz7oEa/8AmIPG1s+CLL46HaQNTg7VdOn9vQBYIhukyttmZ89 INNhAh3LEPHw9LPiQkRqndj02ll2DCdgClOJJtRR8f/k5HS79+nUkEEksUWmuRNkqbETOjNJ1Tc 9qtwiU3JUREfZMCU4cGnAN1E5f6QwJVGPA0qCKOZV2l5YiTsZ5kaFrB8QP7cPDMcU9uteJw9lgp ppGN0j6EP1B+qPGf54uRGY209kwqSP646uM5wZtv+lzn5LHbZm//IWgTP0HTdjjVNP2NbnJKg/+ BHfnjpNs6ncSbDIR3xwfOoOGYQ+4oj34+k14t937yROqmKs0k8O0mFp1IN8t+5AuZDHZBYZgDgA IRGu5psVsaqH3vUCkiHv+y50LUW1qaaFgVdfwM2CdurrtDjaTms75AFBCxKMhwOo1avfoWJjkWS eJeJYJqH6ecWQtvLdFrR0FUtiGm4QMYoFPaaMVEpgUYjJbU= X-Received: by 2002:a05:6512:3c86:b0:5bf:a34f:14ce with SMTP id 2adb3069b0e04-5c1b7bcb80cmr1048858e87.11.1795162269671; Fri, 20 Nov 2026 00:11:09 -0800 (PST) Received: from NB-6746.corp.yadro.com ([188.243.183.76]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5c1bd018b3asm395463e87.32.2026.11.20.00.11.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2026 00:11:09 -0800 (PST) From: Artem Shimko To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, maxime.chevallier@bootlin.com, pavel@ucw.cz Cc: Artem Shimko , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v3 0/4] net: phy: dap8211r: add LED control support Date: Fri, 20 Nov 2026 11:10:58 +0300 Message-ID: <20261120081106.2919010-1-a.shimko.dev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, This series adds support for LEDs on the DAP8211R Gigabit Ethernet PHY. The first patch fixes mistaces in functions comment about locking mdio. The second patch documents the optional "leds" node in the Device Tree binding. The third patch introduces a small helper to write extended registers, since the LED registers are accessed indirectly via EXT_ADD/EXT_DATA. The forth patch implements the three LED callbacks required by the PHY library. $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/dptel,dap8211r.yaml SCHEMA Documentation/devicetree/bindings/processed-schema.json CHKDT ./Documentation/devicetree/bindings LINT ./Documentation/devicetree/bindings STYLE ./Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/net/dptel,dap8211r.example.dts DTC [C] Documentation/devicetree/bindings/net/dptel,dap8211r.example.dtb $ yamllint Documentation/devicetree/bindings/net/dptel,dap8211r.yaml $ grep -i "dap8211r" Documentation/devicetree/bindings/processed-schema.json "http://devicetree.org/schemas/net/dptel,dap8211r.yaml": { "$filename": "/home/a-shimko/patchwork/linux/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml", "$id": "http://devicetree.org/schemas/net/dptel,dap8211r.yaml#", "title": "DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY", Required: CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=y CONFIG_LEDS_TRIGGERS=y CONFIG_LEDS_TRIGGER_NETDEV=y Testing: $ ip link set eth1 up $ ls /sys/class/leds/ stmmac-1:01:amber:lan stmmac-1:01:green:lan $ echo netdev > /sys/class/leds/stmmac-1:01:green:lan/trigger $ echo eth1 > /sys/class/leds/stmmac-1:01:green:lan/device_name $ echo 1 > /sys/class/leds/stmmac-1:01:green:lan/link_1000 $ cat /sys/class/leds/stmmac-1:01:green:lan/offloaded $ ip addr add 192.168.5.100/24 dev eth1 $ ping -I eth1 192.168.5.1 $ echo netdev > /sys/class/leds/stmmac-1:01:amber:lan/trigger $ echo eth1 > /sys/class/leds/stmmac-1:01:amber:lan/device_name $ echo 1 > /sys/class/leds/stmmac-1:01:amber:lan/tx $ echo 1 > /sys/class/leds/stmmac-1:01:amber:lan/rx $ cat /sys/class/leds/stmmac-1:01:amber:lan/offloaded $ echo none > /sys/class/leds/stmmac-1:01:amber:lan/trigger $ echo 1 > /sys/class/leds/stmmac-1:01:amber:lan/brightness $ echo netdev > /sys/class/leds/stmmac-1:01:amber:lan/trigger $ echo 1 > /sys/class/leds/stmmac-1:01:amber:lan/tx $ echo 1 > /sys/class/leds/stmmac-1:01:amber:lan/rx $ ip addr add 192.168.5.100/24 dev eth1 $ ping -I eth1 192.168.5.1 -- Best regards, artem shimko ChangeLog: v3: - fix kernel-doc comment for DAP8211R_LED_FORCE_MODE_ON and DAP8211R_LED_FORCE_MODE_MASK - use FIELD_PREP() for DAP8211R_LED_FORCE_MODE_ON v2: - add a commit fixing kernel-doc comments for dap8211r_read_ext() and dap8211r_modify_ext() - move LED child node down below tx-internal-delay-ps in dptel,dap8211r.yaml - add blank lines in dptel,dap8211r.yaml - restrict LED reg index to 0..2 and fix schema properties in dptel,dap8211r.yaml - fix kernel-doc comment for dap8211r_write_ext() - add LED brightness (force mode) support to driver - remove rules == 0 statement - add TRIGGER_NETDEV_LINK to DAP8211R_LED_SUPPORTED_TRG for dap8211r_led_hw_is_supported() - clean up switch (index) statements - Link: https://lore.kernel.org/all/CAOPX74709XiLXLoioDJStTSzzhstC2sHpM4GieAO=3-37E18pw@mail.gmail.com/T/#u v1: - Link: https://lore.kernel.org/all/20261113110546.173624-1-a.shimko.dev@gmail.com/T/#t Artem Shimko (4): net: phy: dap8211r: fix kernel-doc comments for extended register helpers dt-bindings: net: dptel,dap8211r: add LED nodes net: phy: dap8211r: add extended register write helper net: phy: dap8211r: add PHY LED control support .../bindings/net/dptel,dap8211r.yaml | 50 ++++ drivers/net/phy/dap8211r.c | 242 +++++++++++++++++- 2 files changed, 290 insertions(+), 2 deletions(-) -- 2.43.0