The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Zqiang <qiang.zhang@linux.dev>
To: paulmck@kernel.org, frederic@kernel.org,
	neeraj.upadhyay@kernel.org, joelagnelf@nvidia.com,
	urezki@gmail.com, boqun@kernel.org
Cc: qiang.zhang@linux.dev, rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] rcuscale: Disable gp_exp when cur_ops->exp_completed is not implemented
Date: Fri, 20 Nov 2026 18:04:52 +0800	[thread overview]
Message-ID: <20261120100453.5826-3-qiang.zhang@linux.dev> (raw)
In-Reply-To: <20261120100453.5826-1-qiang.zhang@linux.dev>

The tasks, tasks-rude and tasks-tracing scale ops provide exp_sync but
no exp_completed.  Passing gp_exp=1 with one of these scale types makes
the reader, writer and kfree paths call cur_ops->exp_completed(), which
is NULL, resulting in a NULL pointer dereference.

This commit disable gp_exp in rcu_scale_init() when cur_ops->exp_completed
is not implemented.

Signed-off-by: Zqiang <qiang.zhang@linux.dev>
---

# insmod rcuscale.ko scale_type=tasks kfree_rcu_test=1 gp_exp=1

[  957.313922][ T1311] BUG: kernel NULL pointer dereference, address: 0000000000000000
[  957.315073][ T1311] #PF: supervisor instruction fetch in kernel mode
[  957.315918][ T1311] #PF: error_code(0x0010) - not-present page
[  957.316649][ T1311] PGD 0 P4D 0 
[  957.317082][ T1311] Oops: Oops: 0010 [#1] SMP KASAN PTI
[  957.317799][ T1311] CPU: 3 UID: 0 PID: 1311 Comm: kfree_scale_thr Tainted: G        W   E       7.4.0-rc1+ #118 PREEMPT(full)  d93f260d09ad39f5830a6d4abcacc3510ff31cf2
[  957.319925][ T1311] Tainted: [W]=WARN, [E]=UNSIGNED_MODULE
[  957.321343][ T1311] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
[  957.322763][ T1311] RIP: 0010:0x0
[  957.325961][ T1311] Code: Unable to access opcode bytes at 0xffffffffffffffd6.
[  957.327030][ T1311] RSP: 0018:ffff888110a67d88 EFLAGS: 00010246
[  957.334010][ T1311] RAX: 0000000000000000 RBX: ffffffffc00b8d80 RCX: ffffffffc0605ee8
[  957.335015][ T1311] RDX: 1ffffffff80171b7 RSI: 0000000000000004 RDI: ffffffffc00b8db8
[  957.336000][ T1311] RBP: ffff888110a67e48 R08: fffffbfff8017068 R09: fffffbfff8017068
[  957.337000][ T1311] R10: fffffbfff8017068 R11: 0000000000000003 R12: 0000000000000000
[  957.337973][ T1311] R13: 0000000000000000 R14: ffffffffc0605da0 R15: 0000000000000003
[  957.338979][ T1311] FS:  0000000000000000(0000) GS:ffff8882658e2000(0000) knlGS:0000000000000000
[  957.340092][ T1311] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  957.340884][ T1311] CR2: ffffffffffffffd6 CR3: 00000001caaec000 CR4: 00000000000026f0
[  957.343924][ T1311] Call Trace:
[  957.344354][ T1311]  <TASK>
[  957.344739][ T1311]  kfree_scale_thread+0x19c/0x5a0 [rcuscale 4b3bd1c4339388c164c4923083b9e192f124c200]
[  957.345977][ T1311]  ? __pfx_kfree_scale_thread+0x10/0x10 [rcuscale 4b3bd1c4339388c164c4923083b9e192f124c200]
[  957.347251][ T1311]  ? __kasan_check_read+0x15/0x20
[  957.351496][ T1311]  ? __kthread_parkme+0x11e/0x230
[  957.352127][ T1311]  ? __pfx_kfree_scale_thread+0x10/0x10 [rcuscale 4b3bd1c4339388c164c4923083b9e192f124c200]
[  957.353924][ T1311]  kthread+0x3ca/0x500
[  957.354484][ T1311]  ? __pfx_kthread+0x10/0x10
[  957.358092][ T1311]  ret_from_fork+0x7be/0xaf0
[  957.358652][ T1311]  ? __pfx_ret_from_fork+0x10/0x10
[  957.359209][ T1311]  ? __kasan_check_read+0x15/0x20
[  957.359737][ T1311]  ? __switch_to+0x199/0xe90
[  957.360224][ T1311]  ? __switch_to_asm+0x39/0x70
[  957.360725][ T1311]  ? __pfx_kthread+0x10/0x10
[  957.361207][ T1311]  ret_from_fork_asm+0x1a/0x30
[  957.362616][ T1311]  </TASK>

 kernel/rcu/rcuscale.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
index fc19366fc3a6..c9d2a898777b 100644
--- a/kernel/rcu/rcuscale.c
+++ b/kernel/rcu/rcuscale.c
@@ -1186,6 +1186,9 @@ rcu_scale_init(void)
 		if (kthread_tp)
 			kthread_stime = kthread_tp->stime;
 	}
+
+	if (gp_exp && !cur_ops->exp_completed)
+		gp_exp = false;
 	nrealexp = nexp;
 	if (kfree_rcu_test)
 		return kfree_scale_init();
-- 
2.17.1


  parent reply	other threads:[~2026-11-20 10:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 10:04 [PATCH] refscale: Fix possible oops in the typesafe_cleanup() Zqiang
2026-11-20 10:04 ` [PATCH] rcuscale: Handle cur_ops->init() failures for srcu testing Zqiang
2026-11-20 10:04 ` Zqiang [this message]
2026-11-20 10:04 ` [PATCH] rcuscale: Invoke cur_ops->cleanup() in kfree_scale_cleanup() Zqiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120100453.5826-3-qiang.zhang@linux.dev \
    --to=qiang.zhang@linux.dev \
    --cc=boqun@kernel.org \
    --cc=frederic@kernel.org \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neeraj.upadhyay@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox