From: Eli Billauer <eli.billauer@gmail.com>
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
Eli Billauer <eli.billauer@gmail.com>
Subject: [PATCH v3 0/8] char: xillybus: Fix issues reported by Sashiko
Date: Fri, 20 Nov 2026 14:04:54 +0100 [thread overview]
Message-ID: <20261120130502.17056-1-eli.billauer@gmail.com> (raw)
This series is a follow-up to the previously submitted patchset [1].
It addresses Sashiko review comments on surrounding code. This v3 series
is the result of Sashiko's comments on v2 [3], which in turn was the
result of comments on v1 [2]. Another reason for this v3 is to rebase
after the insertion of commit 4dd10fbbeb9c ("treewide: Convert
devm_kmalloc() family to the devm_kmalloc_obj() family").
One Sashiko comment from [2] is not addressed in this patch set:
"Can unbinding the device while a file descriptor is open cause a
use-after-free in xillybus_write()?" This remark is correct, but
will be fixed in a future set of patches, which makes the PCIe
driver hot-pluggable.
The comment about autoflush_skipped in [2] was repeated with a better
motivation in Sashiko's comment [3], so it's followed in this patch
set.
Regards,
Eli
[1] https://lore.kernel.org/all/20261009074557.19996-1-eli.billauer@gmail.com/
[2] https://sashiko.dev/#/patchset/20261109112800.48663-1-eli.billauer@gmail.com
[3] https://sashiko.dev/#/patchset/20261117115902.41359-1-eli.billauer@gmail.com
Eli Billauer (8):
char: xillybus: Improve sanity check
char: xillybus: Safer access of unaligned pointers
char: xillybus: Return error in fops read method handler
char: xillybus: Rely on FMODE flags in poll method
char: xillybus: Refactor flush function
char: xillybus: Correct handling of wait queue
char: xillybus: Avoid indefinite sleep of work item
char: xillybus: Cancel delayed work items before teardown
drivers/char/xillybus/xillybus.h | 3 +
drivers/char/xillybus/xillybus_core.c | 109 ++++++++++++-----
drivers/char/xillybus/xillyusb.c | 166 +++++++++++---------------
3 files changed, 153 insertions(+), 125 deletions(-)
--
2.17.1
next reply other threads:[~2026-11-20 13:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 13:04 Eli Billauer [this message]
2026-11-20 13:04 ` [PATCH v3 1/8] char: xillybus: Improve sanity check Eli Billauer
2026-11-20 13:04 ` [PATCH v3 2/8] char: xillybus: Safer access of unaligned pointers Eli Billauer
2026-11-20 13:04 ` [PATCH v3 3/8] char: xillybus: Return error in fops read method handler Eli Billauer
2026-11-20 13:04 ` [PATCH v3 4/8] char: xillybus: Rely on FMODE flags in poll method Eli Billauer
2026-11-20 13:04 ` [PATCH v3 5/8] char: xillybus: Refactor flush function Eli Billauer
2026-11-20 13:05 ` [PATCH v3 6/8] char: xillybus: Correct handling of wait queue Eli Billauer
2026-11-20 13:05 ` [PATCH v3 7/8] char: xillybus: Avoid indefinite sleep of work item Eli Billauer
2026-11-20 13:05 ` [PATCH v3 8/8] char: xillybus: Cancel delayed work items before teardown Eli Billauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120130502.17056-1-eli.billauer@gmail.com \
--to=eli.billauer@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox