The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Laight <david.laight.linux@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-mips@vger.kernel.org,
	"Maciej W. Rozycki" <macro@orcam.me.uk>,
	Paul Cercueil <paul@crapouillou.net>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] MIPS: Ingenic: Allow assembler reordering in the XBurst secondary entry
Date: Fri, 20 Nov 2026 15:00:35 +0000	[thread overview]
Message-ID: <20261120150035.4ccbad0c@pumpkin> (raw)
In-Reply-To: <20261120050827.804767-1-f.fainelli@gmail.com>

On Thu, 19 Nov 2026 21:08:26 -0800
Florian Fainelli <f.fainelli@gmail.com> wrote:

> Remove .set noreorder and the two explicit delay-slot nops from the
> XBurst secondary CPU reset entry. GNU as emits identical reset-entry
> instructions with reordering enabled in both the CI20 and generic
> MIPS64r2 Ingenic SMP builds.

If the ordering actually mattered then the fact that the current toolchain
doesn't break thinks isn't enough to guarantee that a future version
won't find some way of generating invalid code.

The explicit nop in the delay slots might even be there because there
is another reason for the .set noreorder.

If nothing else the commit message is misleading.

David

> 
> On CI20, two baseline and three updated cold boots brought both CPUs
> online. Each boot passed the CPU affinity check and 100 cross-core
> idle-wakeup round trips in each direction. Codex assisted with the
> assembly comparison and hardware test campaign.
> 
> Suggested-by: Maciej W. Rozycki <macro@orcam.me.uk>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Thomas, feel free to fixup into "MIPS: Ingenic: Add XBurst SMP support"
> if that is simpler. Thanks!
> 
>  arch/mips/ingenic/ingenic-smp-entry.S | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/mips/ingenic/ingenic-smp-entry.S b/arch/mips/ingenic/ingenic-smp-entry.S
> index 290e23c65707..d6aa4b4b1a17 100644
> --- a/arch/mips/ingenic/ingenic-smp-entry.S
> +++ b/arch/mips/ingenic/ingenic-smp-entry.S
> @@ -16,7 +16,6 @@
>  	/* The CP0 REIM register only stores the upper 16 address bits. */
>  	.section .text.smp-entry, "ax"
>  	.balign 0x10000
> -	.set noreorder
>  LEAF(xburst_secondary_cpu_entry)
>  	mtc0	zero, CP0_CAUSE
>  	li	t0, ST0_CU0
> @@ -32,7 +31,6 @@ LEAF(xburst_secondary_cpu_entry)
>  	cache	Index_Store_Tag_D, 0(t0)
>  	addiu	t0, t0, CACHE_LINESIZE
>  	bne	t0, t1, 1b
> -	 nop
>  
>  	mfc0	t0, CP0_CONFIG
>  	li	t1, ~CONF_CM_CMASK
> @@ -50,5 +48,4 @@ LEAF(xburst_secondary_cpu_entry)
>  
>  	PTR_LA	t0, smp_bootstrap
>  	jr	t0
> -	 nop
>  END(xburst_secondary_cpu_entry)


      parent reply	other threads:[~2026-11-20 15:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  5:08 [PATCH] MIPS: Ingenic: Allow assembler reordering in the XBurst secondary entry Florian Fainelli
2026-11-20 14:06 ` Maciej W. Rozycki
2026-11-20 15:00 ` David Laight [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120150035.4ccbad0c@pumpkin \
    --to=david.laight.linux@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=paul@crapouillou.net \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox