The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Hannes Reinecke <hare@suse.de>, Keith Busch <kbusch@kernel.org>,
	"Martin K . Petersen" <mkp@kernel.org>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: stack max_user_discard_sectors
Date: Sat, 21 Nov 2026 01:13:34 +0100	[thread overview]
Message-ID: <20261121001334.GA13058@lst.de> (raw)
In-Reply-To: <awCi_9_Xykc_Mmk-@redhat.com>

On Fri, Nov 20, 2026 at 02:43:59PM -0500, Benjamin Marzinski wrote:
> > I don't think we should take the underlying max_user_discard_sectors
> > into account here, just max_discard_sectors.
> 
> Is that to handle devices that call blk_queue_disable_discard()? I
> didn't think about that. Makes sense.

That too.  But also because user limits on lower devices shouldn't
really affect upper devices for consistency, as new updates on the
lower device after the upper one was created don't get picked up
either.


      reply	other threads:[~2026-11-21  0:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 19:39 [PATCH] block: stack max_user_discard_sectors Benjamin Marzinski
2026-11-20 15:40 ` Christoph Hellwig
2026-11-20 19:43   ` Benjamin Marzinski
2026-11-21  0:13     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121001334.GA13058@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bmarzins@redhat.com \
    --cc=hare@suse.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkp@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox