The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Laight <david.laight.linux@gmail.com>
To: Jim Cromie via B4 Relay <devnull+jim.cromie.gmail.com@kernel.org>
Cc: jim.cromie@gmail.com, Arnd Bergmann <arnd@arndb.de>,
	Jason Baron <jbaron@akamai.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Petr Pavlu <petr.pavlu@suse.com>,
	Daniel Gomez <da.gomez@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Aaron Tomlin <atomlin@atomlin.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-modules@vger.kernel.org,
	Louis Chauvet <louis.chauvet@bootlin.com>
Subject: Re: [PATCH 0/6] dyndbg,vmlinux.lds.h: fix i386 section alignment in BOUNDED_SECTION macros
Date: Sun, 22 Nov 2026 12:02:12 +0000	[thread overview]
Message-ID: <20261122120212.0dda7532@pumpkin> (raw)
In-Reply-To: <20261121-vmlinux-lds-v1-0-49818f3f5cc0@gmail.com>

On Sat, 21 Nov 2026 15:49:18 -0700
Jim Cromie via B4 Relay <devnull+jim.cromie.gmail.com@kernel.org> wrote:

> This series fixes a latent i386 section-alignment bug, by adding
> explicit alignments into the BOUNDED_SECTION_* linker script macros.
> The misalignment appears once __dyndbg_classes is split in 2, and the
> 1st section has just 1 entry; the 2nd section implicitly gets ALIGN(4).

Would everything work if all these sections got an ALIGN(8)?
It would simplify everything and only cost a few bytes of memory
that no one is really going to notice.

(Apart from BTF which seems to be page aligned.)

David

> 
> 1. Refactor BOUNDED_SECTION_* (and HEADERED_SECTION_*) macros from
>    vmlinux.lds.h into include/asm-generic/bounded_sections.lds.h for
>    reuse.
> 
> 2. Drop the unused HEADERED_SECTION* macros from bounded_sections.lds.h.
> 
> 3. Add explicit ALIGN(8) defaults to BOUNDED_SECTION_* (with _ALIGNED
>    variants for non-8-byte tables like ORC_UNWIND_TABLE,
>    EXCEPTION_TABLE, TRACEDATA, INIT_SETUP, and NOTES), fixing an i386
>    NULL deref in dynamic_debug_init() caused by 28-byte
>    __dyndbg_classes misaligning the following __dyndbg section.
> 
> 4. Remove now-redundant outer `. = ALIGN(8);` directives preceding 
>    BOUNDED_SECTION* uses in vmlinux.lds.h.
> 
> 5. Add include/asm-generic/dyndbg.lds.h with DYNDBG_SECTIONS() for 
>    vmlinux.lds.h and MOD_DYNDBG_SECTIONS() (`0 : ALIGN(8)` + `KEEP`) for
>    scripts/module.lds.S, fixing lost __dyndbg* sections in DRM modules 
>    under CONFIG_DRM_USE_DYNAMIC_DEBUG=y.
> 
> 6. fix checkpatch to skip macro-rules checks on any *.lds.h, in 3
>    places where only vmlinux.lds.h is currently skipped.
> 
> NB: most of this patchset was split out of larger series fixing
> dyndbg-classmaps.
> 
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> ---
> Jim Cromie (6):
>       vmlinux.lds.h: refactor BOUNDED_SECTION_* macros into bounded_sections.lds.h
>       vmlinux.lds.h: drop unused HEADERED_SECTION* macros
>       vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386
>       vmlinux.lds.h: remove redundant ALIGN(8) directives
>       dyndbg.lds.S: fix lost dyndbg sections in modules
>       checkpatch.pl: generalize linker script macro exceptions
> 
>  MAINTAINERS                                |  1 +
>  include/asm-generic/bounded_sections.lds.h | 32 ++++++++++++++
>  include/asm-generic/dyndbg.lds.h           | 18 ++++++++
>  include/asm-generic/vmlinux.lds.h          | 68 ++++++------------------------
>  scripts/checkpatch.pl                      |  6 +--
>  scripts/module.lds.S                       |  2 +
>  6 files changed, 69 insertions(+), 58 deletions(-)
> ---
> base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
> change-id: 20261121-vmlinux-lds-b59410146885
> 
> Best regards,


      parent reply	other threads:[~2026-11-22 12:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 22:49 [PATCH 0/6] dyndbg,vmlinux.lds.h: fix i386 section alignment in BOUNDED_SECTION macros Jim Cromie via B4 Relay
2026-11-21 22:49 ` [PATCH 1/6] vmlinux.lds.h: refactor BOUNDED_SECTION_* macros into bounded_sections.lds.h Jim Cromie via B4 Relay
2026-11-21 22:49 ` [PATCH 2/6] vmlinux.lds.h: drop unused HEADERED_SECTION* macros Jim Cromie via B4 Relay
2026-11-22 11:54   ` David Laight
2026-11-21 22:49 ` [PATCH 3/6] vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386 Jim Cromie via B4 Relay
2026-11-21 22:49 ` [PATCH 4/6] vmlinux.lds.h: remove redundant ALIGN(8) directives Jim Cromie via B4 Relay
2026-11-21 22:49 ` [PATCH 5/6] dyndbg.lds.S: fix lost dyndbg sections in modules Jim Cromie via B4 Relay
2026-11-21 22:49 ` [PATCH 6/6] checkpatch.pl: generalize linker script macro exceptions Jim Cromie via B4 Relay
2026-11-22  2:27   ` Joe Perches
2026-11-22 12:02 ` David Laight [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261122120212.0dda7532@pumpkin \
    --to=david.laight.linux@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=atomlin@atomlin.com \
    --cc=da.gomez@kernel.org \
    --cc=devnull+jim.cromie.gmail.com@kernel.org \
    --cc=jbaron@akamai.com \
    --cc=jim.cromie@gmail.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=mcgrof@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox