public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Keith Owens <kaos@ocs.com.au>
Cc: Benjamin LaHaise <bcrl@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: Modutils 2.5 change, start running this command now
Date: Fri, 12 Oct 2001 13:14:41 +0100	[thread overview]
Message-ID: <20283.1002888881@redhat.com> (raw)
In-Reply-To: <7202.1002886635@ocs3.intra.ocs.com.au>
In-Reply-To: <7202.1002886635@ocs3.intra.ocs.com.au>


kaos@ocs.com.au said:
>  I was going to do it that way.  The problem is that it gives no
> indication if the module has been checked or not.  Adding
> EXPORT_NO_SYMBOLS says that somebody has reviewed the module and
> decided that exporting no symbols is the correct behaviour.  It is the
> difference between no maintainer and a maintained module. 

If all you want to know is whether modules are maintained or not, look to 
see how many have had MODULE_LICENSE(sic) tags added. 

Just change the default to no exported symbols, and a single depmod pass
will tell you what broke because it's no longer exporting symbols which are
required by something else. There's no need to add the EXPORT_NO_SYMBOLS
cruft all over the place.

Adding EXPORT_NO_SYMBOLS to those modules which don't need to export 
symbols doesn't make your task any easier - so please don't do it. Let's 
kill EXPORT_NO_SYMBOLS altogether.


--
dwmw2



  reply	other threads:[~2001-10-12 12:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-11 11:45 Modutils 2.5 change, start running this command now Keith Owens
2001-10-12  6:34 ` Ingo Oeser
2001-10-12 10:04 ` Benjamin LaHaise
2001-10-12 11:37   ` Keith Owens
2001-10-12 12:14     ` David Woodhouse [this message]
2001-10-12 14:40       ` Keith Owens
2001-10-12 15:01       ` Tom Rini
2001-10-15 16:05 ` [PATCH] meye camera driver EXPORT_NO_SYMBOLS Stelian Pop
  -- strict thread matches above, loose matches on Subject: below --
2001-10-03  4:36 Modutils 2.5 change, start running this command now Keith Owens
2001-10-03  4:48 ` Robert Love
2001-10-03  8:17 ` Russell King
2001-10-03 11:59   ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20283.1002888881@redhat.com \
    --to=dwmw2@infradead.org \
    --cc=bcrl@redhat.com \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox