From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754140AbeAQXL0 (ORCPT ); Wed, 17 Jan 2018 18:11:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53624 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbeAQXLY (ORCPT ); Wed, 17 Jan 2018 18:11:24 -0500 Date: Wed, 17 Jan 2018 18:11:23 -0500 (EST) From: Ronnie Sahlberg To: Colin King Cc: Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <2031352942.702941.1516230683335.JavaMail.zimbra@redhat.com> In-Reply-To: <20180117095239.10670-1-colin.king@canonical.com> References: <20180117095239.10670-1-colin.king@canonical.com> Subject: Re: [PATCH] cifs: remove redundant duplicated assignment of pointer 'node' MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.54.86, 10.4.195.30] Thread-Topic: cifs: remove redundant duplicated assignment of pointer 'node' Thread-Index: 2JtkT6SVdM+Rpe1NK1AqSspjuPs1Pg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Ronnie Sahlberg ----- Original Message ----- From: "Colin King" To: "Steve French" , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Sent: Wednesday, 17 January, 2018 8:52:39 PM Subject: [PATCH] cifs: remove redundant duplicated assignment of pointer 'node' From: Colin Ian King Node is assigned twice to rb_first(root), first during declaration time and second after a taking a spin lock, so we have a duplicated assignment. Remove the first assignment because it is redundant and also not protected by the spin lock. Cleans up clang warning: fs/cifs/connect.c:4435:18: warning: Value stored to 'node' during its initialization is never read Signed-off-by: Colin Ian King --- fs/cifs/connect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 0efd22e75ac7..63c5d85fe25e 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -4432,7 +4432,7 @@ cifs_prune_tlinks(struct work_struct *work) struct cifs_sb_info *cifs_sb = container_of(work, struct cifs_sb_info, prune_tlinks.work); struct rb_root *root = &cifs_sb->tlink_tree; - struct rb_node *node = rb_first(root); + struct rb_node *node; struct rb_node *tmp; struct tcon_link *tlink; -- 2.15.1