Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

Trond Myklebust
2007-05-05T17:27:23Z

On Sat, 2007-05-05 at 13:20 -0400, Trond Myklebust wrote:
> On Sat, 2007-05-05 at 18:44 +0200, Adrian Bunk wrote:
> > On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.21-rc7-mm2:
> > >...
> > > git-net.patch
> > >...
> > > git trees
> > >...
> >
> > match_table_t was made "const" and gcc doesn't like "const __initdata":
>
> Then please revert the "fix" to match_table_t...
>
> There is no reason for something like the nfsroot parser to be kept in
> memory after the system has booted. That would be code bloat.
>
> Trond

Alternatively, please change the nfsroot parser to use

static struct match_token tokens[] __initdata = {

That is in any case cleaner than using a typedef.

Trond