public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Walch <walch.martin@web.de>
To: David Rientjes <rientjes@google.com>, linux-kbuild@vger.kernel.org
Cc: "Michal Marek" <mmarek@suse.cz>,
	"Jiri Kosina" <trivial@kernel.org>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Benjamin Poirier" <bpoirier@suse.de>,
	"Dirk Gouders" <dirk@gouders.net>,
	"Wang YanQing" <udknight@gmail.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Jean Delvare" <jdelvare@suse.de>,
	"Kees Cook" <keescook@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE
Date: Thu, 03 Oct 2013 01:39:13 +0200	[thread overview]
Message-ID: <2034014.asIXrEbcsn@tacticalops> (raw)
In-Reply-To: <alpine.DEB.2.02.1310012236360.5682@chino.kir.corp.google.com>

> > diff --git a/scripts/kconfig/expr.h b/scripts/kconfig/expr.h
> > index df198a5..ba663e1 100644
> > --- a/scripts/kconfig/expr.h
> > +++ b/scripts/kconfig/expr.h
> > @@ -93,7 +93,7 @@ struct symbol {
> >  #define SYMBOL_CHOICEVAL  0x0020  /* used as a value in a choice block */
> >  #define SYMBOL_VALID      0x0080  /* set when symbol.curr is calculated */
> >  #define SYMBOL_OPTIONAL   0x0100  /* choice is optional - values can be 'n' */
> > -#define SYMBOL_WRITE      0x0200  /* ? */
> > +#define SYMBOL_WRITE      0x0200  /* write symbol to file (KCONFIG_CONFIG) */
> >  #define SYMBOL_CHANGED    0x0400  /* ? */
> >  #define SYMBOL_AUTO       0x1000  /* value from environment variable */
> >  #define SYMBOL_CHECKED    0x2000  /* used during dependency checking */
> 
> Perhaps stating that the choice is writable by the user?

As far as I understand SYMBOL_WRITE, its main purpose is in the function
conf_write in confdata.c:

>if (!(sym->flags & SYMBOL_WRITE))
>	goto next;
>sym->flags &= ~SYMBOL_WRITE;
>
>conf_write_symbol(out, sym, &kconfig_printer_cb, NULL);

So, if I have not missed anything, SYMBOL_WRITE decides whether to write a symbol
to .config or not. This does not necessarily mean that the user can change the value.
SYMBOL_WRITE may be set and the symbol may be written to .config while the user
does not even see the corresponding prompt.

  reply	other threads:[~2013-10-02 23:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-02  5:24 [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE Martin Walch
2013-10-02  5:37 ` David Rientjes
2013-10-02 23:39   ` Martin Walch [this message]
2013-10-02 23:42     ` David Rientjes
2013-10-03  0:26       ` Martin Walch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2034014.asIXrEbcsn@tacticalops \
    --to=walch.martin@web.de \
    --cc=akpm@linux-foundation.org \
    --cc=arve@android.com \
    --cc=bpoirier@suse.de \
    --cc=dirk@gouders.net \
    --cc=jdelvare@suse.de \
    --cc=keescook@chromium.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rientjes@google.com \
    --cc=trivial@kernel.org \
    --cc=udknight@gmail.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox