public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Liran Alon" <liran.alon@oracle.com>,
	vkuznets@redhat.com, x86@kernel.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] x86/kvm: disable fast MMIO when running nested
Date: Thu, 25 Jan 2018 09:49:22 -0500 (EST)	[thread overview]
Message-ID: <2039380511.2539348.1516891762406.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <aaccbf48-ec7d-10bf-9980-8db0ae36b506@redhat.com>

> > Michael and Jason, any progress on implementing a fast virtio mechanism
> > that doesn't rely on undefined behavior?
> >
> > (Encode writing instruction length into last 4 bits of MMIO address,
> >   side-channel say that accesses to the MMIO area always use certain
> >   instruction length, use hypercall, ...)
> >
> > Thanks.
> 
> No progress from my side. But we can use PIO for virtio 1.0 and it's
> faster than fast MMIO (qemu supports modern pio notification bar, we can
> make it as default). It looks to me that neither encoding nor hypercall
> will work for real hardware virtio device.

Encoding the instruction length would work, the h/w virtio devices would
just ignore it.  But... it is really ugly.

Using PIO would be a small step backwards for PCIe.  As long as the device
only needs *one* notification register (either MMIO or PIO) to initialize
successfully, it's okay.  Then if there is no PIO space you'd just fall back
to the slower MMIO notification.

Paolo

  reply	other threads:[~2018-01-25 14:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25  9:55 [PATCH] x86/kvm: disable fast MMIO when running nested Liran Alon
2018-01-25 14:16 ` Radim Krčmář
2018-01-25 14:39   ` Jason Wang
2018-01-25 14:49     ` Paolo Bonzini [this message]
2018-01-25 17:11       ` Michael S. Tsirkin
2018-01-26  2:41         ` Jason Wang
2018-01-26  2:49           ` Michael S. Tsirkin
2018-01-26  3:21             ` Jason Wang
  -- strict thread matches above, loose matches on Subject: below --
2018-01-24 15:12 Vitaly Kuznetsov
2018-01-25  7:55 ` Wanpeng Li
2018-01-25 14:34 ` Radim Krčmář
2018-01-25 14:34 ` Paolo Bonzini
2018-01-25 14:49   ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2039380511.2539348.1516891762406.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liran.alon@oracle.com \
    --cc=mst@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=vkuznets@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox