From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966268AbcIYLON (ORCPT ); Sun, 25 Sep 2016 07:14:13 -0400 Received: from mout.web.de ([212.227.15.14]:54864 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938386AbcIYLOL (ORCPT ); Sun, 25 Sep 2016 07:14:11 -0400 Subject: [PATCH 4/5] ISDN-CAPI: Adjust checks for null pointers in four functions To: netdev@vger.kernel.org, Karsten Keil References: Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <20395fb4-0899-eb2a-c0ce-cca8bf6fd6f0@users.sourceforge.net> Date: Sun, 25 Sep 2016 13:14:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:3esdXYCAL+rHPjVhuGmsondLVqoEs5p4t+xsZ6Eggxsry8mJhBz pkH0scZPIzgOuHMe7hoseIVWWMsf5WWhzshQOUNv/GIk6Qqk3IHGOGKZDWTkudns03CSKhe eSOghbotc4Cbus6MDDmD3xHfVpFxNrPC2leDb2Qc8v63C/Vl6oOrA1Gu9fJVm+u9M8Zbb9T mZWC+WyTxdI/IL6KMzwOQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:rAJSRsmRzqg=:a/7VWI/hI2MJLwL0n9VTcZ rO+v3iRC6/l2t3XvLrIlYFLJL2NQgJP0Ys3lP7cFcgnaxfNalP0ZnxPtldpBLvaHQJCqn9yaR HMHCrTS+aA4o1NQjfUEG9pkRheOZNO6m2bmSCewkkb8LS/xIgNwHY3VunvhbG+2PuHP7E8ygJ MvKAJRilBaWsLBxTGknZvhghtW/JaGh5L7dHFxywHn5/q4Bqf2GbrAvi8r2t30v/UYih+5cE4 Mhvo8YSZAgXqryDHA39PNMjY5j9hnrXbr9czDo+Qau/Iz6018arQPNX/H7bT0woBsfOb7wZ1M 3M1hQeTpcYPUy5B9abVJaGfpZy6i3J18QJg23GOYUfe7KOhKJhsdxzqrYzwxXzY93JMjZvmw6 C2Um8HK9LXbWHa7FSDKYoASdet2iVHKoE4ViZ1A5+0vfIxxPyKMkGUxvM0gxkQHcz3nYLARke wTGdXB7KQYeYet1+uXHh1cY1lYyzxPhyTCEkvk7cUVBkkC2pYiPrpfsN1VlmrAxYXZwwa11AX VtYev4xK5bKkg6dXOPBMB1JvXx0VHJ2x+Ct8/fG1ufCQSPRo5fmJebiDr3vf/5tknX0YcpZ4O Nk/mUTKHTXvlAGiMuov9LUdzSxLCxc7q7bIlFeK56yPUrFhsODYssxuaLVboK1j1d+x77dIPK Hr7nEf0gKS50XGcgnA9xLIDzDDNcDGQMU4EJutXi/UArtA4dAdpHZbD5qXMujQ9/YcIEzUzl/ sR8x5Ybe+VEGo3xcFNk3g1O2LPM5+wqFjWH82ZPg41YUZcEz6pAV4JWOnxBfiJNo9w52gXpNl OecmrFS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 25 Sep 2016 12:26:38 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/isdn/capi/capidrv.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c index bd614e3..83f756d 100644 --- a/drivers/isdn/capi/capidrv.c +++ b/drivers/isdn/capi/capidrv.c @@ -334,8 +334,7 @@ static capidrv_plci *new_plci(capidrv_contr *card, int chan) capidrv_plci *plcip; plcip = kzalloc(sizeof(capidrv_plci), GFP_ATOMIC); - - if (plcip == NULL) + if (!plcip) return NULL; plcip->state = ST_PLCI_NONE; @@ -403,8 +402,7 @@ static inline capidrv_ncci *new_ncci(capidrv_contr *card, capidrv_ncci *nccip; nccip = kzalloc(sizeof(capidrv_ncci), GFP_ATOMIC); - - if (nccip == NULL) + if (!nccip) return NULL; nccip->ncci = ncci; @@ -757,7 +755,7 @@ static inline int new_bchan(capidrv_contr *card) { int i; for (i = 0; i < card->nbchan; i++) { - if (card->bchans[i].plcip == NULL) { + if (!card->bchans[i].plcip) { card->bchans[i].disconnecting = 0; return i; } @@ -2192,7 +2190,7 @@ static void enable_dchannel_trace(capidrv_contr *card) card->name, errcode); return; } - if (strstr(manufacturer, "AVM") == NULL) { + if (!strstr(manufacturer, "AVM")) { printk(KERN_ERR "%s: not from AVM, no d-channel trace possible (%s)\n", card->name, manufacturer); return; -- 2.10.0