public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <zbr@ioremap.net>
To: David Fries <david@fries.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] w1: bundle reply if the request was bundled
Date: Fri, 21 Feb 2014 01:07:28 +0400	[thread overview]
Message-ID: <204041392930448@web28m.yandex.ru> (raw)
In-Reply-To: <20140219071911.GA26209@spacedout.fries.net>

Hi

19.02.2014, 11:19, "David Fries" <david@fries.net>:
> A program can bundle multiple messages and commands together when
> making one wire requests, which is going to be much more efficient
> than sending lots of little packets one write at a time.  With this
> change the kernel will then bundle responses to requests that were
> bundled, where it's probably even more important because programs will
> typically execute select or a poll operation between reading packets,
> which takes additional context switches.


Your approach and patch seem correct, but I worry about how old commands are processed.
Do I get it right, that replies to old non-bundle commands are queued back instead of sending immediately,
but since it is not bundle but single command, queued reply is being sent 'almost' immediately?
Basically, nothing changed to old clients, but there is new way to send batch requests now?

And please make indent less paranoid about line length, it is really hard to read some lines,
which were broken into pieces just because of that.

  reply	other threads:[~2014-02-20 21:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 16:08 [patch] w1: small type cleanup in sysfs Dan Carpenter
2014-02-11 16:45 ` David Fries
2014-02-11 21:07   ` [patch v2] " Dan Carpenter
2014-02-14 15:42     ` Evgeniy Polyakov
2014-02-19  7:19       ` [PATCH] w1: bundle reply if the request was bundled David Fries
2014-02-20 21:07         ` Evgeniy Polyakov [this message]
2014-02-11 21:12   ` [patch] w1: small type cleanup in sysfs Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=204041392930448@web28m.yandex.ru \
    --to=zbr@ioremap.net \
    --cc=david@fries.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox