From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752352AbcF1HBZ (ORCPT ); Tue, 28 Jun 2016 03:01:25 -0400 Received: from mout.web.de ([212.227.15.14]:64421 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbcF1HBX (ORCPT ); Tue, 28 Jun 2016 03:01:23 -0400 From: Alexander Stein To: Arnd Bergmann Cc: Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, "devicetree@vger.kernel.org" , Linus Torvalds , "Linus Walleij (linus.walleij@linaro.org)" Subject: Re: linux-next: Tree for Jun 27 (pinctrl && !CONFIG_OF) Date: Tue, 28 Jun 2016 09:00:47 +0200 Message-ID: <2044946.aGLaEK2W6I@ws-stein> User-Agent: KMail/4.14.10 (Linux/4.6.0-gentoo; KDE/4.14.20; x86_64; ; ) In-Reply-To: <735717690.oeI6DkomRc@wuerfel> References: <20160627163939.20e454d5@canb.auug.org.au> <57716D3D.4070302@infradead.org> <735717690.oeI6DkomRc@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:73iP6X1h7qu9Fio3NiUn0yAl2288VrY1NRouz1UUHpOlvRakerF 3PDdhuD8snepyx1DeyYkyccKQskYfRPyPiL+ne+trX5ujuKpOEY/UC9loaH9p3cdMyNz5Am mcEBuP7xl5i0gf+1/Gciio0GXY02JTZdFjpMcyzRX0w7OaHCX+4NGVAEZ7r1nvomFkdu6Kp ryggiN6KzK2bJHP4mm/Qg== X-UI-Out-Filterresults: notjunk:1;V01:K0:c0akaaCVsL8=:8Z3tj5uiOFHsl1UO2+lg81 bQp9brU0waP4f4rL9nC4m3O+jGvl8/6K5grkqeTTMp/FET+BF38YbM4ro1pr5gLZUBjVkrlmB Z2oTyIfW/YS66ClXJJM6fGrkMTNoqEUOmZ/OQtLVmgR8iqcQqSbnNoy+2uFgKtfwkVUD4PK0c yZotr5476KJgRxmoiy/sraoiiJ0tFRJi8eKHgFRnLYgA7PX0fzBOZIljqltekF47Jg9xRtPG9 NRG15Z/IqBSsFXy2VgzM4DyZHHZMFSx8KhO6qYVR8zt1my4c5V42OLjmEACp0DrSaWFstobgf +7P8og8kYYB7C54v/ctoIP2p2kAdl4guuwRcuMXykQImsXKwfC1fzPJKo0S4lTEIEEy9sF1zd SaGfQ8xkw22APiBIf/Nnojawx2BXlilwzqLjbBOMQs3yBO76tLm8AtyDYplcw8LDT7rbZMIuD 3XPBnbOX8yOXWZJ6u7YSL8UYJ3FDNmTihAPMeW56rd576S5jOii4LALDDPQ2fW/ovA68qSfcO 1f8qUjc15CUGZSBHzFxfUvvNSq2SOK0lqODN5Ld3SaVdyF+lUIxFPolQCxOYJS/Ad6dBhWw6H 8/PXIfavmkwDMJl94kZAwo1l5q9UU3lBw4BI9lSYbscmTs35LoDKvwsnLNRYMiRGad4s3D3Pv 5+YiLfrsFdJKzhqXq8I7+GWAbthpJHSynWG8oP+b6hkN2Jmvtg/X5aN5LfXxdn5LhqwmkyrkS MFcM4ok+wTIcHdHB1BE3mEnPWofUYHNr9NOq78zLa2q1HPQl0NnMM36/x6vpaophMhu5oHY79 MfRwRav Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 27 June 2016 23:36:29, Arnd Bergmann wrote: > On Monday, June 27, 2016 11:15:25 AM CEST Randy Dunlap wrote: > > On 06/26/16 23:39, Stephen Rothwell wrote: > > > Hi all, > > > > > Changes since 20160624: > > on i386, when CONFIG_OF is not enabled ... > > but OF_GPIO is enabled due to this in drivers/gpio/Kconfig: > > > > config OF_GPIO > > > > def_bool y > > depends on OF || COMPILE_TEST > > > > (above from commit 1e4a80640338924b9f9fd7a121ac31d08134410a > > from Alexander Stein ) > > > > > > ../drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:381:20: error: > > 'pinconf_generic_dt_node_to_map_pin' undeclared here (not in a function) > > ../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: > > 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a > > function) ../drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:365:20: error: > > 'pinconf_generic_dt_node_to_map_pin' undeclared here (not in a function) > > > > because that function is only present when CONFIG_OF is enabled. > > > > > > Also, why does that commit (1e4a80640338924b9f9fd7a121ac31d08134410a) > > not have any other S-O-B lines in it? like whoever merged it? > > (adding Linus Walleij and Alexander Stein to Cc) > > Unfortunately, the changelog also doesn't say what triggered that > change. I guess there was a driver that did 'select OF_GPIO' > and had a dependency on COMPILE_TEST, though I don't see any > driver doing that in linux-next. It was the first change of the changes done in my branch https://github.com/AlexanderStein/linux/tree/gpio-compile-test in order to compile test as much gpio drivers as possible. Yet, pinctrl drivers were out of my scope. > I think the commit should just be reverted, it clearly breaks > stuff, and whatever needs it can be fixed in a better way. Why not depend PINCTRL_IPROC_GPIO on CONFIG_OF as Randy stated pinconf_generic_dt_node_to_map_pin and friends are only present if CONFIG_OF is enabled. Depending on OF_GPIO only is enough under the assumption a) you made below. Also what about providing dummy implementation for those missing function in case CONFIG_OF is disabled, my preference as more code can be compile tested. > Specifically, we have three ways that the OF_GPIO symbol > is used: > > a) it is implicitly enabled when both GPIOLIB and OF are turned on or if COMPILE_TEST is enabled I think a problem in this and possibly other cases is that COMPILE_TEST loosens the Kconfig dependencies to some degree. How to proceed? Allow compile testing drivers only if some optional settings are enabled? Best regards, Alexander