From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Kyrie Wu (吴晗)" <Kyrie.Wu@mediatek.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"kyrie.wu@mediatek.corp-partner.google.com"
<kyrie.wu@mediatek.corp-partner.google.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v3 01/12] dt-bindings: media: mediatek,jpeg: Add mediatek, mt8196-jpgdec compatible
Date: Tue, 29 Apr 2025 09:33:58 +0200 [thread overview]
Message-ID: <2044b305-8786-49b9-82e2-aa294434c24e@kernel.org> (raw)
In-Reply-To: <5b6e70181b417f1b25df6fc1838b0ad600e29e9c.camel@mediatek.com>
On 28/04/2025 10:19, Kyrie Wu (吴晗) wrote:
> On Mon, 2025-04-28 at 09:04 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Fri, Apr 25, 2025 at 04:53:17PM GMT, Kyrie Wu wrote:
>>> Compared to the previous generation IC, the MT8196 uses SMMU
>>> instead of IOMMU and supports features such as dynamic voltage
>>> and frequency scaling. Therefore, add "mediatek,mt8196-jpgdec"
>>> compatible to the binding document.
>>>
>>> Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
>>
>> I gave you a link to the exact part of documentation about prefixes
>> to
>> read. I do not see improvements, so I do not believe you read it. I
>> could
>> imagine people skip reading entire doc (who would listen to the
>> reviewer, right?), but if I give direct link to specific chapter and
>> still not following it, makes me feel quite dissapointed.
>>
>> Best regards,
>> Krzysztof
>>
> Dear Krzysztof,
>
> I would like to apologize to you again here. I am very sorry for
> wasting your precious time. I changed the subject from "dt-bindings:
> mediatek: XXX" to "dt-bindings: media: mediatek,jpeg: XXX" in V3. This
> change is based on your previous suggestion. Use this command, git log
> --oneline --
> Documentation/devicetree/bindings/media/, obtained. But this
> modification does not meet your requirements. Should I change the
> subject to "media: dt-bindings: mediatek,jpeg: XXX"?
>
> Another question I need to ask you:
> MT8195 and MT8196 both have multi-core hardware architectures. Do we
> need to change the yaml file name from 'mediatek,mt8195-jpegenc.yaml'
> to 'mediatek,multi-core-jpegenc.yaml'? In my opinion, this is more
> appropriate. What is your suggestion?
I asked above about link to documentation. You ignored that part, so
let's be specific:
Did you or did you not read the doc I linked last time?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-29 7:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 8:53 [PATCH v3 00/12] Enable jpeg enc & dec multi-hardwares for MT8196 Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 01/12] dt-bindings: media: mediatek,jpeg: Add mediatek, mt8196-jpgdec compatible Kyrie Wu
2025-04-28 7:04 ` Krzysztof Kozlowski
2025-04-28 8:19 ` Kyrie Wu (吴晗)
2025-04-29 7:33 ` Krzysztof Kozlowski [this message]
2025-04-29 8:25 ` Kyrie Wu (吴晗)
2025-05-08 9:01 ` Kyrie Wu (吴晗)
2025-04-25 8:53 ` [PATCH v3 02/12] dt-bindings: media: mediatek,jpeg: Add mediatek, mt8196-jpgenc compatible Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 03/12] media: mediatek: jpeg: add jpeg compatible Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 04/12] media: mediatek: jpeg: add jpeg smmu sid setting Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 05/12] media: mediatek: jpeg: fix jpeg hw count setting Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 06/12] media: mediatek: jpeg: refactor jpeg buffer payload setting Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 07/12] media: mediatek: jpeg: refactor jpeg dst buffer layout Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 08/12] media: mediatek: jpeg: fix stop streaming flow for multi-core Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 09/12] media: mediatek: jpeg: refactor multi-core clk suspend and resume setting Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 10/12] media: mediatek: jpeg: fix decoding buffer number setting timing issue Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 11/12] media: mediatek: jpeg: refactor decoding resolution change operation Kyrie Wu
2025-04-25 8:53 ` [PATCH v3 12/12] media: mediatek: jpeg: fix remove buffer operation for multi-core Kyrie Wu
2025-04-28 7:01 ` [PATCH v3 00/12] Enable jpeg enc & dec multi-hardwares for MT8196 Krzysztof Kozlowski
2025-04-28 8:10 ` Kyrie Wu (吴晗)
2025-04-29 7:34 ` Krzysztof Kozlowski
2025-04-29 8:34 ` Kyrie Wu (吴晗)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2044b305-8786-49b9-82e2-aa294434c24e@kernel.org \
--to=krzk@kernel.org \
--cc=Kyrie.Wu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=kyrie.wu@mediatek.corp-partner.google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox