From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761773AbcIXJJk (ORCPT ); Sat, 24 Sep 2016 05:09:40 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:61602 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754313AbcIXJJj (ORCPT ); Sat, 24 Sep 2016 05:09:39 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: mturquette@baylibre.com, sboyd@codeaurora.org, linus.walleij@linaro.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] clk: versatile: add missing header dependencies Date: Sat, 24 Sep 2016 11:09:17 +0200 Message-ID: <2048131.z1JiX2E8WD@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1474691500-19793-1-git-send-email-baoyou.xie@linaro.org> References: <1474691500-19793-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Gj8qJRvkz17FXn/AYP49V1ruEYa9QWCmNWTBHDJe1beuRFFjH9K LKYiCwPsKWOa0qbH6XSZ9S3U5IwA01BY4aqqDognbpHbF5EA2AY2aJnqDXKFgiTiHg7JMNH YMrssBGNiZSnrGUMFXQ44zFZAkqz6tycQQVyW/Row6S1SMD2fm/M3+9AUS/RFLBhx5k5K+U KG4TcYI/szjkNzCKSgL5g== X-UI-Out-Filterresults: notjunk:1;V01:K0:NOaB+6v/zzw=:OjlqN+9p0wNTe3I9jXjplh jgHLK5/QqIdR35AAYR/Z9k/fBfRLD3ggk6ObNKawFfIUAFVJnEPbsoeTKdtKgjH185wL1e8lJ PDq+E+e6hJ9LJFrrwJLjIpM2sf2W5Jl3EwWIRHUXcPUrJEz7eiNLUTLqqvsJ+7zEmHbUN9w4b 7GlEbIn2PXowtDteSn8kXKRP7ptUutWj4kRTy9bRRs1cl4cJLeFSmZ7MkT3dOma+EqhE6R5CP TgjIlQdYU6QSfgND5PlQr3XTsMZTi7pq0HUYMO21HN95mFrs6aJBPGmbTYmdccbiGi21wA5hQ fVV5UTh6wmxYB18OJEnbAKyyYRYUxKuubYlmBI2qokluhq3QOm6HFHXZ8ZU+m5+a8PVU62DsZ ijzdxqouKjwpMlLILUFJblzpn8VQAICXJdNP5srPzEz1Ym7ryz6iIEPy5Scud7FGMIinviFaT iRgMqO0VET+pgV9GOQl2aJ+s1LcaaWBuWKTHecs+Tap+AWxhPzSPWQ9ey9HCgj2wHKBrApz3e eyhnx7xpGfUWAxxCb7cx7ltqrFnLFNQuglreOwpXAowMCLTrt2c1lK5PfCXq8bOMIPrDRMJZ+ th+LUTyxz9moOrkeAmufvFuS9wKE/GQzHMVs/OJxjgCh/ViinnIcnkAXrtxLmSEhq0NnI00Sa wS2ect6tPR8Ns81wTNni+LghoN7Y1joPEkuiFUQlR+qaUQjyyMdWn2FBK1eAB+5YFBK2JZJ/m oCLwTNwhJiZkGSOl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 24, 2016 12:31:40 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes] > > In fact, this function is declared in > include/linux/platform_data/clk-realview.h, > so this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie > I think I commented on this one already: the only caller of the function is getting removed in v4.9, so we should remove the definition of the function subsequently in the next release. We could in theory try to remove this at the same time, but the effort to synchronize the git trees is not worth the benefit. Arnd