From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbbFXHy5 (ORCPT ); Wed, 24 Jun 2015 03:54:57 -0400 Received: from mail.eperm.de ([89.247.134.16]:47854 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751656AbbFXHyh (ORCPT ); Wed, 24 Jun 2015 03:54:37 -0400 From: Stephan Mueller To: Dan Carpenter Cc: SF Markus Elfring , "David S. Miller" , Herbert Xu , linux-crypto@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] crypto-jitterentropy: Delete unnecessary checks before the function call "kzfree" Date: Wed, 24 Jun 2015 09:54:26 +0200 Message-ID: <20504077.rM6dY01J5R@tauon.atsec.com> User-Agent: KMail/4.14.9 (Linux/4.0.5-300.fc22.x86_64; KDE/4.14.9; x86_64; ; ) In-Reply-To: <20150624074819.GR28762@mwanda> References: <5307CAA2.8060406@users.sourceforge.net> <3056833.hq1kqBmzGz@myon.chronox.de> <20150624074819.GR28762@mwanda> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 24. Juni 2015, 10:48:19 schrieb Dan Carpenter: Hi Dan, >The other NULL assignment isn't useful either. Also If >"entropy_collector" is NULL then we would oops calling >kzfree(entropy_collector->mem); > ^^^^^^^^^^^^^^^^^^^^^^ >Dereference. > >I don't understand the patch that you sent. We shouldn't be introducing >jent_zalloc() or jent_zfree(). Why are you adding abstractions there? The one C file should have no dependencies on any kernel header files. Thus, all links to kernel functions are wrapped. >Quite bad ones as well. What would you suggest to change? Thanks. Ciao Stephan