Re: [PATCH] hfsplus: Convert kmap() to kmap_local_page() in bitmap.c

Matthew Wilcox
2022-07-26T20:38:15Z

On Tue, Jul 26, 2022 at 12:11:50PM -0700, Ira Weiny wrote:
> On Mon, Jul 25, 2022 at 06:54:50PM +0100, Matthew Wilcox wrote:
> > On Mon, Jul 25, 2022 at 10:17:13AM -0700, Viacheslav Dubeyko wrote:
> > > Looks good. Maybe, it makes sense to combine all kmap() related modifications in HFS+ into
> > > one patchset?
> >
> > For bisection, I'd think it best to leave them separate?
>
> I'm not quite sure I understand why putting the individual patches into a
> series makes bisection easier? It does make sense to keep individual patches.

If somebody reports a bug, bisection will tell you which of these
kmap-conversion patches is at fault, reducing the amount of brainpower
you have to invest in determining where the bug is.