Re: [reiserfs-list] major security bug in reiserfs (may affect SuSE Linux)

Chris Mason
2001-01-10T16:09:51Z

On Wednesday, January 10, 2001 07:02:08 PM +0300 "Vladimir V. Saveliev"
<vs@namesys.botik.ru> wrote:

> Hi
>
> Chris Mason wrote:
>
>> On Wednesday, January 10, 2001 02:32:09 AM +0100 Marc Lehmann
>> <pcg@goof.com> wrote:
>>
>> >>> EIP; c013f911 <filldir+20b/221> <=====
>> > Trace; c013f706 <filldir+0/221>
>> > Trace; c0136e01 <reiserfs_getblk+2a/16d>
>>
>> The buffer reiserfs is sending to filldir is big enough for
>> the huge file name, so I think the real fix should be done in VFSland.
>>
>> But, in the interest of providing a quick, obviously correct fix, this
>> reiserfs only patch will refuse to create file names larger
>> than 255 chars, and skip over any directory entries larger than
>> 255 chars.
>>
>
> Hmm, wouldn't it make existing long named files unreachable?
>

Yes, that was intentional. We can make a different version of the patch
that changes reiserfs_find_entry to allow opening the large filenames for
delete and such. But, as a quick fix, I wanted to close all possible paths
to the long names.

-chris