From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2075.outbound.protection.outlook.com [40.107.93.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2415B2356CE for ; Mon, 17 Mar 2025 11:26:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.75 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742210810; cv=fail; b=S0K7LnlWvAUm+GS9+mtr+BYOgUI9p4+Q7ojTpb3rkG/4QzOMlkZ5tyh6eH3X8hOYsYtBBLRZ48WL1xwZdef8TE7SP03Te3SugQKL+L64l4jTCRxs6i/tiS+dQalBdYpYtGA1oguSRzH+9BQugQ0efaKSZ+B7rO29vC0pkVwaJb4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742210810; c=relaxed/simple; bh=QZfpnWSyBmXoeqL1QnhDtL1gmdSrq2F2oVmkxktXrx4=; h=Message-ID:Date:Subject:To:References:From:In-Reply-To: Content-Type:MIME-Version; b=lsap5FmrFPxM18J7gRYwz5K5KXE347eZbXJWR3GrkO20DuyOteP6yvXRJvbVff4WkvPpeq3rOZi9HtbDQws3dkOZsKvkvkoqt54o5rftFw7ZS7/yqH1eiDmukp2Oyf1n0ApgjXclKe+ihhOyBTr73waQH1X+JiOiNjnDrh0voYQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=S/lubWrG; arc=fail smtp.client-ip=40.107.93.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="S/lubWrG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jrJMfq8N2dKcLiz9cUMxgePe9vcZMkbMW4OkPtuaQ5NvInCKRN3nh+vs9jguBmRmzIYvfMlHok/dWbgLU7yU/2Gq3ZhdNj8Y+na/oCoMk/hBjv7WyLnmQSi2dHFS03fajaCWpE/sCBA17+oARDSV3kn4Yh+xynNRJJya2zXAM8QZPQjDAI1V0O6IrfjE6NmLMlQ9cvqbEc/cHxmLfwfKx9ONAXgGIlMXiRdF3YdD4RJ1sle60aoyGDuTCz1tTa8Eo7128cTUS4VbDjqIj3At8fkST/XIUzUxLcNzzlm7tTHc9k/OsYIfRvmSQRPUwdjXvEUvscU3nEZczvX3c/PGKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A7YHWxidU6gSbAPQIArreuRb+vhUPvjPX292AnCcg1s=; b=u7HWgvib4hl4Bt24NwvIXMKYU0SO6I2M+GfnjuavIeo5TBPcQase+pz5XwU3wY+LV9iYrGI27u9epInwhNU6RKE4VeBVxAYHK7j0KPVl/2Ra1F0rqiwsBJ+agwlqgaCYIrh6Es506/6ARu5v+VWBB5hV28dz+IqTNPBsEDwDN9Fm/DEHgema/daQGfiqWGXrzZ26WBUQrChZwbDkez6x80au40ZKM4q5t+ohv+LYyJMvr2l7W8lpb5SZpNQtBp4p3Rx7n/sjGeVP2NjAevYvCWx7rE6tHgBUwC8m+prWP9LFEUelLkdAT+brdYsVECI8RUE2VfAfruM61YtC3o/wGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A7YHWxidU6gSbAPQIArreuRb+vhUPvjPX292AnCcg1s=; b=S/lubWrG8StQhb48GWtR9p6xMcXPpXT9a1tlJQ4vY6w1JxbOICLfnzC547EOutYlrO6Sc0vshPy1DD3KTjkkLuA5w9WKndI8v+odgUFP9AdBS+Lf0tkzPYy0cxgjTxEKD4oEG2bQLPNi6v8moB5pwf2ZaNMtFOgu2PIGJBCxZiA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BN9PR12MB5163.namprd12.prod.outlook.com (2603:10b6:408:11c::7) by DS7PR12MB8251.namprd12.prod.outlook.com (2603:10b6:8:e3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33; Mon, 17 Mar 2025 11:26:47 +0000 Received: from BN9PR12MB5163.namprd12.prod.outlook.com ([fe80::61ca:6d43:a98d:3b7f]) by BN9PR12MB5163.namprd12.prod.outlook.com ([fe80::61ca:6d43:a98d:3b7f%6]) with mapi id 15.20.8534.031; Mon, 17 Mar 2025 11:26:46 +0000 Message-ID: <205328f3-8b1b-4e1d-afa8-da6a123866e2@amd.com> Date: Mon, 17 Mar 2025 16:56:39 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/8] iommu/amd: Add debugfs support to dump IRT Table To: Vasant Hegde , joro@8bytes.org, suravee.suthikulpanit@amd.com, will@kernel.org, robin.murphy@arm.com, linux-kernel@vger.kernel.org, iommu@lists.linux.dev References: <20250206060003.685-1-dheerajkumar.srivastava@amd.com> <20250206060003.685-8-dheerajkumar.srivastava@amd.com> Content-Language: en-US From: Dheeraj Kumar Srivastava In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2P287CA0008.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:21b::13) To BN9PR12MB5163.namprd12.prod.outlook.com (2603:10b6:408:11c::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN9PR12MB5163:EE_|DS7PR12MB8251:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a515200-15c9-4f1d-64e4-08dd654699ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eE90aE1ndmRWRFQwWm5rQlcyN3J3bFhNc2ZpUE1PK1BqSHZ2dWcrR0FWMXF3?= =?utf-8?B?ZmdKYlB5bm95MUJna25aZ001Y3BHckdpdCttZ283L1B3cHVsZ1ZmbWtodENh?= =?utf-8?B?NHlxcldNSUltUDV2SHdKa3BhNjJXenFra0M2QzhrVmEyR1d1S3pRUTB5UnJX?= =?utf-8?B?UjVnWW53cmZCa0U0aDFJWFpPOW15TTVFTFNBQzNYK1V1aXpoYVhoR1dHalB2?= =?utf-8?B?WEpra0tFT3RUYlF0SkQrSjZXTzZqSklRZHlNSndOY1YvclFBMjFUT0p4SkNL?= =?utf-8?B?ZEhoc2N4NlBKcVpHcWlGUWxiZWlwbXFvZWxaeThUTkxzZnp6QjNPSzVjdXg2?= =?utf-8?B?bHg2YkxZdDRjQ1lTbHVTUmF4cytTT2FoSjg3SHM0RmozSXBicmpJUnV5RC8z?= =?utf-8?B?b0F3N2hDWXJVWU43eXJQNThyUTExb2J5Y3VPL0h4MFZUR0xQMC9lQW9XLzY4?= =?utf-8?B?aXN0dHpIdWhKeFpwcjFKalZRbDlPZHBjVjFpYnlEaUw5bkd3MHZOUnhXb1p4?= =?utf-8?B?aEVaRGhYcVVNdmo2QndIN2grY3d3Tk1pWFdLOW5MVllOY1daZjc5RTdHWVpl?= =?utf-8?B?Y1F5MVFzUWhocStBRE42dGR1RnZwN2haVUN1ckQzeFZMR01vdTQ2ckJFNk9s?= =?utf-8?B?bUNhVi9NTXlkZFNJQ0pVRmx5cHBRODNGa09rV2JpTmFUV1RXY01JbndPR0di?= =?utf-8?B?allSMnI0SVZ1YmY4bVMxdGdCOWM4KytSbGZpMTZTMnBpMHRLZVhCN3l4ZWUv?= =?utf-8?B?Qm1uTmlScVQrVkJ1V0lDUUxhLzlNQUlJZ21PMU5HY1VITDh0WEhhTUVESmgy?= =?utf-8?B?UEM1aUU5SU1QdWkwRGhCY1NTTVZTblNqeWpIemNKN3lBdm5xNjFEVVliYzJB?= =?utf-8?B?S2VSTkxEbW11QmJjRVZzZjZpLzdrNkdZdjIxOGtxQjBRZkM5c3VTZG9zWTZq?= =?utf-8?B?L3MwMU82aXUwanluTVNDV1BJb0M4eFYzZXRrSnA1ZVlpN2VzanpPTlNtNlY1?= =?utf-8?B?VTROSUhrM3R1SHV5M1h2dDkyUVJzMU9yV3JLRXZzZFVPYjJYOTBFdEZPbklH?= =?utf-8?B?RUdtWVhOUU1OMTV5UzY5Wk5hYS9MWHNxOUJNNnU2WXpUaUVha0NMTXRsNTRX?= =?utf-8?B?Qy9pT3lUNXhvRUc5OUdQajYzZnhqRU9lYkZiWjA3aDljNmU5bDBYLzNjd001?= =?utf-8?B?eVN6WXR2SDVxTW5LOVU2TFZ6M21aNWZ6SUFETVJDV2lOdTB5Y1lIS3pjMnpZ?= =?utf-8?B?Vy9jbU5oR29RNHc1MWdGYmxGNEhCcnJzUmFsc0c4aE04aGpzZW5Sa0krSENI?= =?utf-8?B?VFBzc0hSd2xLS3ZzVHU1d09ONEZJeUJxbXc1ZXNmUUNSWnJqeGl1VGxBamx3?= =?utf-8?B?R3c4NmdxTUJrVTM1b0dLeEJPZ1lySVYwTFBORG1FUjZNczBsU2c5dDNRNVN1?= =?utf-8?B?SkxacWNOSlVCQU85QXRrTXE0UjRjSHplK1VWRUhvVnhPblFFNkZPcXIxanhs?= =?utf-8?B?MEdrRHhRenZvNE5yMHdLMldraEt5T2hWcHM0SHZuNHNRMDNpOGZnYUVSSlB1?= =?utf-8?B?Z2E1NjJQL24vQlgzb2s1ZFRycks5SjFJbVcrRHcyU0kycWlSc2FOdzh4TWl0?= =?utf-8?B?RkJRekRoYUZlZ3d4ekpHWDNHRjY5VUFJOWMvV3FhMGVFR0kydjh0cWV2ZWtF?= =?utf-8?B?TFdLclZ4dGRqdlpTdE5IK0MvNXZFS3FwS1dubTZPUW9TcVg1R1o4YnN5NUdQ?= =?utf-8?B?T1JlTlp6d1VET3ZRd1hCTzM5bU1Ib01rUGpZeERYVkZibGVZbGJFdlUwdlFL?= =?utf-8?B?d1FST2llMC9OMWFxL282eXhQeklCMWx4dm45aXROMkFmL2h5T2tnWjJsTlFp?= =?utf-8?Q?++J38Y+XGZpDI?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5163.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEVzSGYyTkIyUFRnWkwzZ0M0RHExQWtzL2lObWRzNkVBZkFyMlkxS3JYNGp1?= =?utf-8?B?RHpaY0RtNHlmaFJnWlJPUVJJSmhaOC91NDhseEZRVVdwUU9Ua2taT2FvVE1l?= =?utf-8?B?WjZvdFk2djUySkJ4cWhpRlZTZi83WWZUZndWWnBmRENHZ2R1M3N0d0J5eG9M?= =?utf-8?B?UHVmU3BRcUlDRjZCWk9vRWdGYjVOL3hmclpCblVxMTVnSm90MjNSSXQ1dlZ6?= =?utf-8?B?ZVpyeE1DcDdwYmVPMDNvRWhSUWJOamI4c3hpY3kzZmsxS3diY080dDhBWWVK?= =?utf-8?B?cFdsS21JZ1I0VmV0TU1WbVU3RlZNUHlBckRwNDZxZlptV3AvMGd2SEZ3ZldE?= =?utf-8?B?a2UvSy9pYTJONjNTUVFjLzlCRGcxbGVRcGhRNGtLNi9BOXdVQUtnWUxkbjR5?= =?utf-8?B?VEN2YVpnM1VhMStQek4va1ZOZmYzRkJvdTJuRFg3QkFuM2pvSUl2SE9Yd0x3?= =?utf-8?B?NkVFcldvVmlYd28yMy9CUUhzYVRvOWZuTm5EV2VqWUp6VHo2KzRXM0hBTU9q?= =?utf-8?B?RVFvenlOMHF6TURxN0E2REh1cmlJUjNCTCt0aE9wcWlrNmJ6clhpRDV0VWtO?= =?utf-8?B?RWtRUkt1STRyNDlONzA5cFRCOHl5bGUzVEFFdjJhbldCSG9aYWFZYUw0NGVU?= =?utf-8?B?eDBwYkVLdHlUbmxoV0dIV1YyRHdrcFRYMW9wNzBtaUlUZVkwNlJRSTR1SnZk?= =?utf-8?B?aVoranhjTzBIUGs3S013QkdNdWJ5Yncrek4wM00rWk5sLy9uN2w0ZC9zM1dv?= =?utf-8?B?aGt5a2lKMVVORjIyWDFodXpmZ2ZIM1Y2dC9BZkllcEYvL2FNN2xHY2dZd2pT?= =?utf-8?B?NGd3WHRSejdqRVlTUGx1ajBFcDM3SnJaaWMzbTcxaW5GTlcyRk1jU1lVelpX?= =?utf-8?B?aG56em1hWjYvcmpJNms3RXdYNGIzS2Z6MTF2VGd1cVEzT3ZQZ1JmTmdndndV?= =?utf-8?B?N0lGY1lJZkJkY0gxUlJzc3pSNlUwUkdWcjFGS0hMS1JwWHNxS0FHU1VTWEZ2?= =?utf-8?B?Q1poK3FtaDcvV3k1S0dlZXpDRldDakUvRUJHcGZYR3d5UFdJaTViUGQzakNk?= =?utf-8?B?QWpKc2NYUVU1ZjhKS1JFMTFCWHpiZVdWdDZNdXBZUW1lNFJ1QVpFK29ja3h6?= =?utf-8?B?OWdMS0tOSTZ6RjBlUnVscG9PRERyZXlNS1FFS3hiZ0c3NjJEQzZIS3NLU2Q0?= =?utf-8?B?emdHL2YvMkxkdGZ4N0ZPM3RZUklNSVVscTJIVlJ4VzR0ZzhVVFBNemJmYTNH?= =?utf-8?B?Q2V4a09vTXRlUGRwaEJZd29haVZDYkpXbXBabTdVemxLcC9vcVNQZThCTnNR?= =?utf-8?B?WnlaL0ZNN29aeURGei9UUFZBYTV1SFB0Z2ZoMkhzQWxLSEVpZFRvK1VGUGpV?= =?utf-8?B?UUY4emFPOW1IU2FNd2FscExZQ3Y3a3cxWU9mTUszUUl4ZkNlTzRqZVAwTzRu?= =?utf-8?B?WnhXUFJ1ekNZZTU1TjVvbWNMU0tibFNGaDRwS2duL0ZhODZtZU5FV3dlaERW?= =?utf-8?B?RUxJVnlCbk9wbHJaSTlsaitJWGw5Mi82Z0oxZ29NaHVQVFRXV0VWTjJEWUFG?= =?utf-8?B?YTZTT1hPYVdGTmROTm5BTjA5YjJiQXpobTE4amdieUpCQTd1RktRUlc3WE5i?= =?utf-8?B?NGUvSHhJUEJCcC9yd2NwNU1CcG0rZ1lMRXdieUUyZ1dHQTJXbzFFWjhBbnE1?= =?utf-8?B?N1BMVUVMM2RhajNadFl5NDB5Z3JJa3F2bTNCQ3I2MUoxbzg4NDM5M08wdlhr?= =?utf-8?B?a3JRUENZV0lkc1d3eWsyTzdRTmJxMzBvcWpqVzY4NEtJeklrTjVSQThlV3FI?= =?utf-8?B?UVNjT2M2NkR1UjJlMEMweFA1ZXFlRmMwVTY1L2kxUVpHZnJGL1BFU2hYamFF?= =?utf-8?B?c2hhVlFiUEVJR1JOOE1XM1FTVG9nd1RZT01iK1BFNVpkaVNwd09rTFl3bUJl?= =?utf-8?B?dlRhamJQSGJpNHpnT2x1NDZqdXRiL0pNdTQ0S0hiWmJEM2dmQkczU2xwTXpX?= =?utf-8?B?d2plZFIrUUQxVkpyQUM5OHJsU0s4bytGM1ZCb2Vab01EZjl1UnJDbTNRS1Fp?= =?utf-8?B?aGR1SW8xRHpFV0Jka1RxTkhxTzdoMXRNNm9aODNIUDRCMThVSzZtcmhMNXNa?= =?utf-8?Q?0HGZIjcsCI73W9V8dsMwQpKxu?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a515200-15c9-4f1d-64e4-08dd654699ee X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5163.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2025 11:26:46.3276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hzSuWxfQGe22+YTLhGnpeoK/4SBqkU+Rmp2nco/6m95IhyH8USJ6IPMJDOqTEOa7NvqFyahQBZCj/Q8W9kjccg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8251 Hi Vasant, On 3/13/2025 4:33 PM, Vasant Hegde wrote: > Hi, > > > On 2/6/2025 11:30 AM, Dheeraj Kumar Srivastava wrote: >> In cases where we have an issue in the device interrupt path with IOMMU >> interrupt remapping enabled, dumping valid IRT table entries for the device >> is very useful and good input for debugging the issue. >> >> eg. >> To dump irte entries for a particular device >> #echo "c4:00.0" > /sys/kernel/debug/iommu/amd/devid >> #cat /sys/kernel/debug/iommu/amd/irqtbl | less >> >> or >> >> #echo "0000:c4:00.0" > /sys/kernel/debug/iommu/amd/devid >> #cat /sys/kernel/debug/iommu/amd/irqtbl | less >> >> Signed-off-by: Dheeraj Kumar Srivastava >> --- >> drivers/iommu/amd/debugfs.c | 89 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 89 insertions(+) >> >> diff --git a/drivers/iommu/amd/debugfs.c b/drivers/iommu/amd/debugfs.c >> index 1377795814d1..0aff1d616108 100644 >> --- a/drivers/iommu/amd/debugfs.c >> +++ b/drivers/iommu/amd/debugfs.c >> @@ -11,6 +11,7 @@ >> #include >> >> #include "amd_iommu.h" >> +#include "../irq_remapping.h" >> >> static struct dentry *amd_iommu_debugfs; >> >> @@ -250,6 +251,92 @@ static int iommu_devtbl_show(struct seq_file *m, void *unused) >> } >> DEFINE_SHOW_ATTRIBUTE(iommu_devtbl); >> >> +static void dump_128_irte(struct seq_file *m, struct irq_remap_table *table) >> +{ >> + struct irte_ga *ptr, *irte; >> + int index; >> + >> + for (index = 0; index < MAX_IRQS_PER_TABLE; index++) { >> + ptr = (struct irte_ga *)table->table; >> + irte = &ptr[index]; >> + >> + if (AMD_IOMMU_GUEST_IR_VAPIC(amd_iommu_guest_ir) && >> + !irte->lo.fields_vapic.valid) >> + continue; >> + else if (!irte->lo.fields_remap.valid) >> + continue; >> + seq_printf(m, "IRT[%04d] %016llx%016llx\n", index, irte->hi.val, irte->lo.val); > > Can you please space between words so that its easy to read? Sure. Will update in v4. Thanks Dheeraj > > -Vasant > >