From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757230AbbJVKTs (ORCPT ); Thu, 22 Oct 2015 06:19:48 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:60401 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757204AbbJVKTq (ORCPT ); Thu, 22 Oct 2015 06:19:46 -0400 From: Arnd Bergmann To: Eric Auger Cc: eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org, linux-kernel@vger.kernel.org, patches@linaro.org Subject: Re: [PATCH v2 5/6] vfio: platform: use list of registered reset function Date: Thu, 22 Oct 2015 12:19:33 +0200 Message-ID: <20554656.kA5nRBgtaJ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1445506922-6005-6-git-send-email-eric.auger@linaro.org> References: <1445506922-6005-1-git-send-email-eric.auger@linaro.org> <1445506922-6005-6-git-send-email-eric.auger@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:2fugEA7hjN72WQ5eWi13mN8HF1h3xYAC3H/VdtX7GNYAhwzOvFR U8RwRnRFJrjPFygyooZu0bRXv4F+YoN6YqDL6vUuqmFESrngaHiprLxW1uIfJ/tU+3DGKzE uwxQIQC068lWP/eX3xakm2eu8OUl6MmYfAGWfj3blj36LCA9eWARDgLfcr/IiUh/NqtpzmD Hw4DED9/2s/DBokMtnF5A== X-UI-Out-Filterresults: notjunk:1;V01:K0:Xv7xNV258M0=:mhACss0zrMv2ZgX2M5WCNA cfO1grzJCLoKsIjbDZbY/BSo2ipbLYVwnfKL+ap+sXrOSP5aOhkiHmloiu0CI0tVV3Eikbyas x4hnSeQ1/OpXWwl8xQCj307RLVPqZY/Ihgf0PcPcH+o64+4LWEw0RsgdQIP/5TnaAefK9axB3 pfQl8nZwF52Qu3bxWqQa7ink6LHyAVxT6YtTFltTKGwVo01aqEMAMtsQy5kLq5/TUUJ3N6Lfp Lz7o5PJxt4w94rcfkifPBz2ewOYCVeI4/GZzp38MENlRxVBkvggqoJgxfoEzpJMq9qdEkbteb ZxqrZPZjt7p59OPX2Pr2DyjT8OvJzwvDWEvagPyuZi9eumxHgXL5wGrxYdzPfiuFSKizhpg9f cObR9tF9kDDi55/Fq4G1BsHWz4zih0rjeh0nlP6qRLCSVYY/fkWbW3jzTd5TGOl0OFg/1rRz2 LUFdomucX15FxZOA7aGWGOOeM1PhzKWJ9nk8BHJNreevCb5okKGr+E/wv4V9NDe8QydfaeDnm RlDqt4ZgJk32FMMMluChPxtj/Ts7NwTa2wQOXgRKlO8tkdgJ2Qdw873wGmdxKHeBwGh8Dmmtg SG5vZbCP7MTeJ/2WC5xBU1/aFFUa4vEGJkfv9BlzOQ4TiLKWPn3yxKeyhO+C6ZZbFPJECjmeY WUrmRaby/YqmgHIKTgR3/GZpLbnHya/HFsuWPsYQ9Dzfxii6/r4lWhJXkl3tFqX3CwAuniUbl sg9P/j5Yeky1IIwP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 22 October 2015 11:42:01 Eric Auger wrote: > Remove the static lookup table and use the dynamic list of registered > reset functions instead. Also load the reset module through its alias. > The reset struct module pointer is stored in vfio_platform_device. > > We also remove the useless struct device pointer parameter in > vfio_platform_get_reset. > > This patch fixes the issue related to the usage of __symbol_get, which > besides from being moot, prevented compilation with CONFIG_MODULES > disabled. > > Also usage of MODULE_ALIAS makes possible to add a new reset module > without needing to update the framework. This was suggested by Arnd. > > Signed-off-by: Eric Auger > Reported-by: Arnd Bergmann Looks good, just small style issues: > > - } > + mutex_lock(&reset_lock); > + list_for_each_entry(iter, &reset_list, link) { > + if (!strcmp(iter->compat, compat) && > + try_module_get(iter->owner)) { > + *module = iter->owner; > + mutex_unlock(&reset_lock); > + return iter->reset; > } > } > + > + mutex_unlock(&reset_lock); > + return NULL; Better use 'break' to have a single mutex_unlock and return statement. > + > > static void vfio_platform_put_reset(struct vfio_platform_device *vdev) > { > - if (vdev->reset) > - symbol_put_addr(vdev->reset); > + if (vdev->reset) { > + module_put(vdev->reset_module); > + vdev->reset_module = NULL; > + vdev->reset = NULL; > + } > } This gets called from the remove callback. No need to clear those struct members immediately before the kfree(). Arnd