From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: myungjoo.ham@gmail.com
Cc: Rajagopal Venkat <rajagopal.venkat@linaro.org>,
Kevin Hilman <khilman@linaro.org>,
Alan Stern <stern@rowland.harvard.edu>,
patches@linaro.org, linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] PM / devfreq: Fix compiler warnings
Date: Tue, 02 Apr 2013 02:16:38 +0200 [thread overview]
Message-ID: <2056616.R7YExf9Ucu@vostro.rjw.lan> (raw)
In-Reply-To: <CAJ0PZbQNTLEmJQ_sRnByNCzwTKs84dGA7Ap2Yj5KRPefoeNsyw@mail.gmail.com>
On Thursday, March 28, 2013 03:03:12 PM MyungJoo Ham wrote:
> On Wed, Mar 27, 2013 at 10:52 PM, Rajagopal Venkat
> <rajagopal.venkat@linaro.org> wrote:
> > Fix compiler warnings generated when devfreq is not enabled
> > (CONFIG_PM_DEVFREQ is not set).
> >
> > Signed-off-by: Rajagopal Venkat <rajagopal.venkat@linaro.org>
>
> Thanks!
>
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Applied.
Thanks,
Rafael
> > ---
> > include/linux/devfreq.h | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
> > index 04ad61d..5f1ab92 100644
> > --- a/include/linux/devfreq.h
> > +++ b/include/linux/devfreq.h
> > @@ -215,7 +215,7 @@ struct devfreq_simple_ondemand_data {
> > #endif
> >
> > #else /* !CONFIG_PM_DEVFREQ */
> > -static struct devfreq *devfreq_add_device(struct device *dev,
> > +static inline struct devfreq *devfreq_add_device(struct device *dev,
> > struct devfreq_dev_profile *profile,
> > const char *governor_name,
> > void *data)
> > @@ -223,34 +223,34 @@ static struct devfreq *devfreq_add_device(struct device *dev,
> > return NULL;
> > }
> >
> > -static int devfreq_remove_device(struct devfreq *devfreq)
> > +static inline int devfreq_remove_device(struct devfreq *devfreq)
> > {
> > return 0;
> > }
> >
> > -static int devfreq_suspend_device(struct devfreq *devfreq)
> > +static inline int devfreq_suspend_device(struct devfreq *devfreq)
> > {
> > return 0;
> > }
> >
> > -static int devfreq_resume_device(struct devfreq *devfreq)
> > +static inline int devfreq_resume_device(struct devfreq *devfreq)
> > {
> > return 0;
> > }
> >
> > -static struct opp *devfreq_recommended_opp(struct device *dev,
> > +static inline struct opp *devfreq_recommended_opp(struct device *dev,
> > unsigned long *freq, u32 flags)
> > {
> > - return -EINVAL;
> > + return ERR_PTR(-EINVAL);
> > }
> >
> > -static int devfreq_register_opp_notifier(struct device *dev,
> > +static inline int devfreq_register_opp_notifier(struct device *dev,
> > struct devfreq *devfreq)
> > {
> > return -EINVAL;
> > }
> >
> > -static int devfreq_unregister_opp_notifier(struct device *dev,
> > +static inline int devfreq_unregister_opp_notifier(struct device *dev,
> > struct devfreq *devfreq)
> > {
> > return -EINVAL;
> > --
> > 1.7.10.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-04-02 0:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 13:52 [PATCH v2 0/2] Add devfreq runtime pm support Rajagopal Venkat
2013-03-27 13:52 ` [PATCH v2 1/2] PM / devfreq: Fix compiler warnings Rajagopal Venkat
2013-03-28 6:03 ` MyungJoo Ham
2013-04-02 0:16 ` Rafael J. Wysocki [this message]
2013-03-27 13:52 ` [PATCH v2 2/2] PM / devfreq: tie suspend/resume to runtime-pm Rajagopal Venkat
2013-04-03 18:16 ` Kevin Hilman
2013-04-04 10:41 ` Rajagopal Venkat
2013-04-04 10:48 ` Rajagopal Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2056616.R7YExf9Ucu@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=khilman@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@gmail.com \
--cc=patches@linaro.org \
--cc=rajagopal.venkat@linaro.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox