public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: [PATCH 2/4] Char: stallion, prints cleanup
Date: Sun, 22 Oct 2006 17:48:51 +0200 (CEST)	[thread overview]
Message-ID: <20637171152004418878@wsc.cz> (raw)

stallion, prints cleanup

Too many information is printed out (they may be easily obtained through
sysfs), wipe them out in probe function. Convert rest of them to dev_
variants.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

---
commit d69255dafff0fbf775d8ec4de1479cf3cc31b977
tree 47f12a708cd50a0fc8767f90d5c90646a8e57366
parent c4a0f4d15661fe74b8c67b0258d5dfbcff57071b
author Jiri Slaby <ku@bellona.localdomain> Sun, 22 Oct 2006 16:43:39 +0159
committer Jiri Slaby <ku@bellona.localdomain> Sun, 22 Oct 2006 16:43:39 +0159

 drivers/char/stallion.c |   15 ++-------------
 1 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/drivers/char/stallion.c b/drivers/char/stallion.c
index 592bd6e..884a578 100644
--- a/drivers/char/stallion.c
+++ b/drivers/char/stallion.c
@@ -2423,9 +2423,6 @@ static int __devinit stl_pciprobe(struct
 	struct stlbrd *brdp;
 	unsigned int brdtype = ent->driver_data;
 
-	pr_debug("stl_initpcibrd(brdtype=%d,busnr=%x,devnr=%x)\n", brdtype,
-		pdev->bus->number, pdev->devfn);
-
 	if ((pdev->class >> 8) == PCI_CLASS_STORAGE_IDE)
 		return -ENODEV;
 
@@ -2437,21 +2434,13 @@ static int __devinit stl_pciprobe(struct
 	if ((brdp = stl_allocbrd()) == NULL)
 		return(-ENOMEM);
 	if ((brdp->brdnr = stl_getbrdnr()) < 0) {
-		printk("STALLION: too many boards found, "
+		dev_err(&pdev->dev, "too many boards found, "
 			"maximum supported %d\n", STL_MAXBRDS);
 		return(0);
 	}
 	brdp->brdtype = brdtype;
 
 /*
- *	Different Stallion boards use the BAR registers in different ways,
- *	so set up io addresses based on board type.
- */
-	pr_debug("%s(%d): BAR[]=%Lx,%Lx,%Lx,%Lx IRQ=%x\n", __FILE__, __LINE__,
-		pci_resource_start(pdev, 0), pci_resource_start(pdev, 1),
-		pci_resource_start(pdev, 2), pci_resource_start(pdev, 3), pdev->irq);
-
-/*
  *	We have all resources from the board, so let's setup the actual
  *	board structure now.
  */
@@ -2469,7 +2458,7 @@ static int __devinit stl_pciprobe(struct
 		brdp->ioaddr2 = pci_resource_start(pdev, 1);
 		break;
 	default:
-		printk("STALLION: unknown PCI board type=%d\n", brdtype);
+		dev_err(&pdev->dev, "unknown PCI board type=%u\n", brdtype);
 		break;
 	}
 

                 reply	other threads:[~2006-10-22 15:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20637171152004418878@wsc.cz \
    --to=jirislaby@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox