The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Hans de Goede <hansg@kernel.org>, Armin Wolf <w_armin@gmx.de>
Subject: [PATCH v1 10/17] ACPI: PAD: Fix teardown ordering in acpi_pad_remove()
Date: Thu, 21 May 2026 16:06:48 +0200	[thread overview]
Message-ID: <2064153.usQuhbGJ8B@rafael.j.wysocki> (raw)
In-Reply-To: <4739447.LvFx2qVVIh@rafael.j.wysocki>

From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>

The ACPI notify handler installed by acpi_pad_probe() needs to be
removed before calling acpi_pad_idle_cpus() in acpi_pad_remove()
so it doesn't schedule idle time injection on some CPUs again.

Fixes: 8e0af5141ab9 ("ACPI: create Processor Aggregator Device driver")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/acpi_pad.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
index b0a6723fb854..48c00ee61ed2 100644
--- a/drivers/acpi/acpi_pad.c
+++ b/drivers/acpi/acpi_pad.c
@@ -430,12 +430,12 @@ static int acpi_pad_probe(struct platform_device *pdev)
 
 static void acpi_pad_remove(struct platform_device *pdev)
 {
+	acpi_dev_remove_notify_handler(ACPI_COMPANION(&pdev->dev),
+				       ACPI_DEVICE_NOTIFY, acpi_pad_notify);
+
 	mutex_lock(&isolated_cpus_lock);
 	acpi_pad_idle_cpus(0);
 	mutex_unlock(&isolated_cpus_lock);
-
-	acpi_dev_remove_notify_handler(ACPI_COMPANION(&pdev->dev),
-				       ACPI_DEVICE_NOTIFY, acpi_pad_notify);
 }
 
 static const struct acpi_device_id pad_device_ids[] = {
-- 
2.51.0





  parent reply	other threads:[~2026-05-21 14:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 13:57 [PATCH v1 00/17] ACPI: driver: Use devres-based resource management Rafael J. Wysocki
2026-05-21 13:59 ` [PATCH v1 01/17] ACPI: bus: Introduce devm_acpi_install_notify_handler() Rafael J. Wysocki
2026-06-02 18:50   ` Andy Shevchenko
2026-06-02 20:57     ` Rafael J. Wysocki
2026-06-02 21:58       ` Andy Shevchenko
2026-05-21 14:01 ` [PATCH v1 02/17] ACPI: NFIT: core: Use devm_acpi_install_notify_handler() Rafael J. Wysocki
2026-05-25 15:40   ` Rafael J. Wysocki
2026-05-21 14:02 ` [PATCH v1 03/17] ACPI: AC: Switch over to devres-based resource management Rafael J. Wysocki
2026-05-21 14:02 ` [PATCH v1 04/17] ACPI: battery: " Rafael J. Wysocki
2026-05-21 14:03 ` [PATCH v1 05/17] ACPI: HED: Refine guarding against adding a second instance Rafael J. Wysocki
2026-05-21 14:04 ` [PATCH v1 06/17] ACPI: HED: Switch over to devres-based resource management Rafael J. Wysocki
2026-06-02 22:10   ` Andy Shevchenko
2026-06-03 10:51     ` Rafael J. Wysocki
2026-06-03 11:12       ` Andy Shevchenko
2026-05-21 14:04 ` [PATCH v1 07/17] ACPI: thermal: " Rafael J. Wysocki
2026-05-21 14:05 ` [PATCH v1 08/17] ACPI: PAD: Rearrange acpi_pad_notify() Rafael J. Wysocki
2026-05-21 14:06 ` [PATCH v1 09/17] ACPI: PAD: Pass struct device pointer to acpi_pad_notify() Rafael J. Wysocki
2026-05-21 14:06 ` Rafael J. Wysocki [this message]
2026-05-21 14:07 ` [PATCH v1 11/17] ACPI: PAD: Switch over to devres-based resource management Rafael J. Wysocki
2026-05-21 14:08 ` [PATCH v1 12/17] ACPI: video: Reduce the number of auxiliary device dereferences Rafael J. Wysocki
2026-05-21 14:08 ` [PATCH v1 13/17] ACPI: video: Rearrange probe and remove code Rafael J. Wysocki
2026-05-21 14:09 ` [PATCH v1 14/17] ACPI: video: Use devm action for video bus object cleanup Rafael J. Wysocki
2026-05-21 14:10 ` [PATCH v1 15/17] ACPI: video: Use devm action for freeing video devices Rafael J. Wysocki
2026-05-21 14:10 ` [PATCH v1 16/17] ACPI: video: Use devm for video->entry and backlight cleanup Rafael J. Wysocki
2026-05-21 14:11 ` [PATCH v1 17/17] ACPI: video: Switch over to devres-based resource management Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2064153.usQuhbGJ8B@rafael.j.wysocki \
    --to=rafael@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hansg@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=w_armin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox