From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756242AbcHXPv4 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 Aug 2016 11:51:56 -0400
Received: from mout.kundenserver.de ([217.72.192.75]:65012 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754876AbcHXPvz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Aug 2016 11:51:55 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Axel Lin <axel.lin@ingics.com>, Hans de Goede <hdegoede@redhat.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Lee Jones <lee.jones@linaro.org>, linux-arm-kernel@lists.infradead.org,
        Alban Bedel <albeu@free.fr>
Subject: Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
Date: Wed, 24 Aug 2016 17:51:06 +0200
Message-ID: <20643424.8eBLZWavEG@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-31-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1472045342-7434-1-git-send-email-p.zabel@pengutronix.de>
References: <1472045342-7434-1-git-send-email-p.zabel@pengutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:pK53VWUvLjhjhoL7p3rBZNtsdP8dmfC3e+Gv0bB8jvqGZDpVWMu
 HKqDitY0NwOJXcjiQMQIgR2+9HQRuDZX8nRDS8n06E26z4hUDmSrq/aQudcnEiIy0noUtE6
 IVQJAVhuokMqDF0KmlQ+QdjCJsb6hlf+0cYFMjYwQsD5Zg2Ca0R1jlB8SJ3FcQ6L+6voLBa
 qpSm58nilM1968VRVYP7g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:OdOkgcLzFjg=:ukpyKLa6P/qgwf5USr9xXJ
 R8BU4RlqIjjngj6/Xnhhv+8Xv7SEy0EElGhFfrc0UUSNBCvOI0NjVbxi+UY1iiEgB9JJT5IjQ
 z6o9LBBoUIdUcGZjw6W8wmgd46GcrE37/CrZkPJknlOFy/bAhrKxvc2WAAMetCfrnyRv+WnLV
 INp6LWK1Kr9V497ebRVubWUQaCedZN9luZ1HpsATy5Ng+GDjMgJ5tKNrPhFCCP/WJTwJh9S/R
 rEUPJa+cvDdjLy0S9yy6oZmOu7J/SqxPwNl0cNgdJhPK0sYUm1dcalS+MmI5FEjBBbU1ivhvA
 AeR2YPSFo6ixSfu0XJ38o12o2spnYssLTiV49R0IMYGzkeljI4AOrKwLwGVos/WPNihcJ5VbA
 2efmoh0sShXG67G3N0GDS09fWai4wULKYqmKcx4pW8TMuVdPs7HcA8Cs7ZgZkq1WZ0GQJf4tl
 PteLFyR2mKMYp/4Ga6Kl47YGOi61gOMP+NGCM/JdAgoPjTIXPpnehOlwdsjFOJmepllli4X/I
 wjFqA/RWjaYUxRRD/OCBkdyxg5K8+KU77Dj/HzuqJeBxg3AGlL9ZgoYnfs7hde72ra/LEwy1X
 okApE9fWuAi0Y8kNKSDE1KxWKE2By/n6MoGSbplMK1irNZaC1gDEW9ZBkOt/H2UmIO+w+tKQE
 AfvWzX2KDnR0zJDtQeDm/dgT1Pih+EUV4998vHl+cMMiLZnOWHVDwX3WmgB9MNo5mf/ED1elS
 5GIGblQLa7qRiq8m
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote:
>  if RESET_CONTROLLER
>  
> +config RESET_ATH79
> +       bool "AR71xx Reset Driver" if COMPILE_TEST
> +       default ATH79
> +       help
> +         This enables the ATH79 reset controller driver that supports the
> +         AR71xx SoC reset controller.
> +
> 

Nice series!

Just note that there is one possible problem with COMPILE_TEST
when the platforms are enabled, as you can then disable a driver
that is normally there, and that can in turn cause problems in
rare cases, e.g. when the driver has a global function that is
called from platform code. I don't know if any of the drivers
do that, but if they do, you'd have to use

config RESET_ATH79
       bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79
       default ATH79

to ensure that it's impossible to disable the driver on platforms
that require it.

	Arnd