linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Martin J. Bligh" <mbligh@aracnet.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix SHMEM options
Date: Fri, 12 Nov 2004 10:50:58 +0000	[thread overview]
Message-ID: <20652.1100256658@redhat.com> (raw)
In-Reply-To: <20041111144153.588094d2.akpm@osdl.org>


> This change permits CONFIG_SHMEM=n on !CONFIG_MMU, even if !EMBEDDED.  Or
> something.  I'm not really sure what it's trying to do, nor am I clear on
> what semantics we wanted to have for CONFIG_SHMEM on CONFIG_MMU machines.
> 
> I think the semantics we want are: you always get shmem, unless you
> selected EMBEDDED.  So perhaps we want:

It boils down to:

 (1) You can't use full shmem if !MMU. You have to use tinyshmem instead.

 (2) On an embedded system, you might want to drop shmem because you don't
     have much flash in which to store your kernel.

This seems to have the desired effect:

	config SHMEM
		bool "Use full shmem filesystem" if EMBEDDED
		depends on MMU
		default y if MMU

David

---

The attached patch fixes the semantics of the SHMEM kernel configuration
option. Manual selectability is not contingent on EMBEDDED being configured,
and the option as a whole is only available if MMU is configured.

Signed-Off-By: David Howells <dhowells@redhat.com>
---
diff -uNrp /warthog/kernels/linux-2.6.10-rc1-mm5/init/Kconfig linux-2.6.10-rc1-mm5-frv/init/Kconfig
--- /warthog/kernels/linux-2.6.10-rc1-mm5/init/Kconfig	2004-11-11 11:48:41.000000000 +0000
+++ linux-2.6.10-rc1-mm5-frv/init/Kconfig	2004-11-12 10:40:28.583887179 +0000
@@ -327,8 +327,8 @@ config CC_OPTIMIZE_FOR_SIZE
 	  If unsure, say N.
 
 config SHMEM
-	bool "Use full shmem filesystem"
-	default y if EMBEDDED
+	bool "Use full shmem filesystem" if EMBEDDED
+	default y if MMU
 	depends on MMU
 	help
 	  The shmem is an internal filesystem used to manage shared memory.

  reply	other threads:[~2004-11-12 10:52 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-11  9:23 2.6.10-rc1-mm5 Andrew Morton
2004-11-11 10:09 ` 2.6.10-rc1-mm5 Magnus Damm
2004-11-11 10:11   ` 2.6.10-rc1-mm5 Andrew Morton
2004-11-11 10:24     ` 2.6.10-rc1-mm5 Magnus Damm
2004-11-11 10:45 ` 2.6.10-rc1-mm5 Brice Goglin
2004-11-11 11:00   ` 2.6.10-rc1-mm5 Stefano Rivoir
2004-11-11 11:13   ` 2.6.10-rc1-mm5 Andrew Morton
2004-11-11 11:04 ` 2.6.10-rc1-mm5 Markus Trippelsdorf
2004-11-11 11:08 ` 2.6.10-rc1-mm5 Andrew Morton
2004-11-11 21:55   ` 2.6.10-rc1-mm5 Martin J. Bligh
2004-11-11 22:14     ` 2.6.10-rc1-mm5 Andrew Morton
2004-11-12  9:27       ` 2.6.10-rc1-mm5 Jens Axboe
2004-11-11 22:41     ` 2.6.10-rc1-mm5 Andrew Morton
2004-11-12 10:50     ` David Howells [this message]
2004-11-12 16:45       ` [PATCH] Fix SHMEM options Christoph Hellwig
2004-11-11 12:11 ` 2.6.10-rc1-mm5: yenta_socket issue Rafael J. Wysocki
2004-11-11 12:21   ` Andrew Morton
2004-11-11 12:43     ` Rafael J. Wysocki
2004-11-12  3:55   ` Rusty Russell
2004-11-11 16:50 ` 2.6.10-rc1-mm5: REISER4_LARGE_KEY is still selectable Adrian Bunk
2004-11-12  7:07   ` Vladimir Saveliev
2004-11-12 13:23     ` Adrian Bunk
2004-11-12 16:16       ` DaMouse
2004-11-12 16:37       ` Vladimir Saveliev
2004-11-12 17:15         ` Adrian Bunk
2004-12-11 17:25   ` Hans Reiser
2004-11-11 21:45 ` Reiser{3,4}: problem with the copyright statement Adrian Bunk
2004-11-11 21:59   ` Linus Torvalds
2004-11-12 16:47     ` Christoph Hellwig
2004-11-12 17:06       ` Christoph Hellwig
2004-11-12 17:11         ` Adrian Bunk
2004-11-12 17:13           ` Christoph Hellwig
2004-11-12 19:33             ` Hans Reiser
2004-11-11 22:51   ` Stephen Pollei
2004-11-12  2:08     ` Zan Lynx
2004-11-11 23:28 ` 2.6.10-rc1-mm5: reiser4: print_clog in debug.c useless? Adrian Bunk
2004-11-12  2:39 ` 2.6.10-rc1-mm5: strange fs/reiser4/linux-5_reiser4_syscall.patch Adrian Bunk
2004-11-12 14:30 ` [patch] 2.6.10-rc1-mm5: some reiser4 cleanups Adrian Bunk
2004-11-12 19:00 ` 2.6.10-rc1-mm5 Alexander Nyberg
2004-11-13  0:11 ` 2.6.10-rc1-mm5 Greg KH
2004-11-13 17:55 ` 2.6.10-rc1-mm5 [u] Martin Schlemmer [c]
2004-11-13 21:16   ` Martin Schlemmer [c]
2004-11-13 21:22     ` Andrew Morton
2004-11-13 22:19       ` Jedi/Sector One
2004-11-13 22:22       ` Martin Schlemmer [c]
2004-11-13 23:24         ` Andrew Morton
2004-11-14  0:07           ` Martin Schlemmer [c]
2004-11-14  9:10           ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20652.1100256658@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@aracnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).