From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Remove four unused semaphores
Date: Sun, 24 Oct 2021 18:27:11 +0200 [thread overview]
Message-ID: <2067076.ETZ9WjcDCG@localhost.localdomain> (raw)
In-Reply-To: <YXVR06W46mx0EaZU@kroah.com>
On Sunday, October 24, 2021 2:30:11 PM CEST Greg Kroah-Hartman wrote:
> On Fri, Oct 22, 2021 at 01:39:36PM +0200, Fabio M. De Francesco wrote:
> > Remove four initialized but unused semaphores.
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
>
> What semaphores were removed? Please be specific.
>
> And can this be broken up into "one removal per patch?"
>
> thanks,
>
> greg k-h
>
Hi Greg,
With all due respect (I mean it), I must say that I'm not going to split this
trivial work into four patches of two lines each.
I understand that here you have the last word. After all, yours the tree,
yours the rules.
However, I'm used to do only what I can understand. After noticing that you
can take in one shot the removal of 7000 unnecessary lines (e.g., please see
commit 7bdedfef085b), I really cannot understand why you cannot take also the
removal of four initialised but unused variables in one only go.
I'm really sorry but, if you cannot reconsider your decision, please drop
this patch. I'm pretty sure that someone else is willing to do what you
required, but not me.
Best regards,
Fabio
prev parent reply other threads:[~2021-10-24 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 11:39 [PATCH] staging: r8188eu: Remove four unused semaphores Fabio M. De Francesco
2021-10-24 12:30 ` Greg Kroah-Hartman
2021-10-24 16:27 ` Fabio M. De Francesco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2067076.ETZ9WjcDCG@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox