From: Thomas Renninger <trenn@suse.de>
To: "Wilck, Martin" <martin.wilck@ts.fujitsu.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"openipmi-developer@lists.sourceforge.net"
<openipmi-developer@lists.sourceforge.net>,
"minyard@acm.org" <minyard@acm.org>
Subject: Re: [patch 1/3] ipmi: Setup ipmi_devintf automatically if ipmi_msghandler gets loaded
Date: Tue, 28 Oct 2014 13:10:19 +0100 [thread overview]
Message-ID: <2067129.5k6o6GOLEd@d46> (raw)
In-Reply-To: <1414147256.8113.41.camel@pdbcooper.pdb.fsc.net>
On Friday, October 24, 2014 12:40:56 PM Wilck, Martin wrote:
> Thomas,
>
>
> > > I vote for MODULE_SOFTDEP for upstream, and modalias for distros that
> > > don't support MODULE_SOFTDEP yet.
> >
> > I vote for ipmi_msghandler.c renaming into ipmi_handler.c
>
>
> sorry, I am not with you here. This is a small problem that should be
> handled with small effort. Why apply a 3-part patch set for a problem
> that can be solved with 2 modalias lines in user space?
Because it is wrong.
In fact this is about a 10 line change.
The file move is no code change at all.
With a modalias added in userspace this will show up in different
distributions again and again.
I agree that a modalias makes sense for SLE and this is probably
what we will go for.
But it would be nice to have this fixed in mainline properly.
Thanks,
Thomas
next prev parent reply other threads:[~2014-10-28 12:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141014144020.683892494@d46.suse.de>
[not found] ` <20141014144315.178850163@d46.suse.de>
2014-10-15 1:22 ` [patch 1/3] ipmi: Setup ipmi_devintf automatically if ipmi_msghandler gets loaded Corey Minyard
2014-10-17 7:49 ` Thomas Renninger
2014-10-17 16:14 ` Corey Minyard
2014-10-20 8:28 ` Wilck, Martin
2014-10-23 9:56 ` Thomas Renninger
2014-10-24 10:40 ` Wilck, Martin
2014-10-28 12:10 ` Thomas Renninger [this message]
[not found] ` <20141014144315.519093022@d46.suse.de>
2014-10-15 1:26 ` [patch 2/3] ipmi: Remove ipmi_major module parameter and define global IPMI_MAJOR Corey Minyard
2014-10-17 7:55 ` Thomas Renninger
2014-10-17 16:21 ` Corey Minyard
[not found] ` <20141014144315.728965695@d46.suse.de>
2014-10-15 1:27 ` [patch 3/3] ipmi: Unregister previously registered driver in error case Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2067129.5k6o6GOLEd@d46 \
--to=trenn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.wilck@ts.fujitsu.com \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox