From: Florian Fainelli <florian@openwrt.org>
To: Kelvin Cheung <keguang.zhang@gmail.com>
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
ralf@linux-mips.org, linux-mips@linux-mips.org, gregkh@suse.de,
wuzhangjin@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6 4/5] USB: Add EHCI bus glue for Loongson1x SoCs (UPDATED)
Date: Tue, 14 Aug 2012 14:49:04 +0200 [thread overview]
Message-ID: <2068844.Lgd4iRJr0U@flexo> (raw)
In-Reply-To: <1326868876-20271-1-git-send-email-keguang.zhang@gmail.com>
Hello Kelvin,
On Wednesday 18 January 2012 14:41:16 Kelvin Cheung wrote:
> Use ehci_setup() in ehci_ls1x_reset().
>
> The Loongson1x SoCs have a built-in EHCI controller.
> This patch adds the necessary glue code to make the generic EHCI
> driver usable for them.
>
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> ---
I do not see this driver doing anything fancy which would require an entirely
new ehci implementation so consider using the generic ehci platform driver
(drivers/usb/host/ehci-platforms.c) instead.
> drivers/usb/Kconfig | 1 +
> drivers/usb/host/ehci-hcd.c | 5 ++
> drivers/usb/host/ehci-ls1x.c | 159
++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 165 insertions(+), 0 deletions(-)
> create mode 100644 drivers/usb/host/ehci-ls1x.c
>
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 85d5a01..78ac78b 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -68,6 +68,7 @@ config USB_ARCH_HAS_EHCI
> default y if ARCH_MSM
> default y if MICROBLAZE
> default y if SPARC_LEON
> + default y if MACH_LOONGSON1
Do this in arch/mips/Kconfig instead.
--
Florian
prev parent reply other threads:[~2012-08-14 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 6:41 [PATCH V6 4/5] USB: Add EHCI bus glue for Loongson1x SoCs (UPDATED) Kelvin Cheung
2012-08-14 12:49 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2068844.Lgd4iRJr0U@flexo \
--to=florian@openwrt.org \
--cc=gregkh@suse.de \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=stern@rowland.harvard.edu \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox