From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Xiang Wang <wangxfdu@gmail.com>
Cc: Xiang Wang <wangx@marvell.com>, Chris Ball <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Marcin Wojtas <mw@semihalf.com>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Chao Xie <cxie4@marvell.com>
Subject: Re: [PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add_host
Date: Wed, 10 Sep 2014 16:24:22 +0300 [thread overview]
Message-ID: <2073138.qpVRy5Xj3H@avalon> (raw)
In-Reply-To: <5513748.05vsM1lCJN@avalon>
On Wednesday 16 July 2014 11:53:21 Laurent Pinchart wrote:
> On Wednesday 16 July 2014 15:50:09 Xiang Wang wrote:
> > From: Xiang Wang <wangx@marvell.com>
> >
> > Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved error
> > handling of sdhci_add_host. However, "err_of_parse" and "err_cd_req"
> > should be placed after "pm_runtime_disable(&pdev->dev)".
> >
> > Signed-off-by: Xiang Wang <wangx@marvell.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I can't find the patch in mainline, has it been lost somewhere ?
> > ---
> >
> > drivers/mmc/host/sdhci-pxav3.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-pxav3.c
> > b/drivers/mmc/host/sdhci-pxav3.c index 2fd73b3..0644655 100644
> > --- a/drivers/mmc/host/sdhci-pxav3.c
> > +++ b/drivers/mmc/host/sdhci-pxav3.c
> > @@ -380,11 +380,11 @@ static int sdhci_pxav3_probe(struct platform_device
> > *pdev)
> >
> > return 0;
> >
> > -err_of_parse:
> >
> > -err_cd_req:
> > err_add_host:
> > pm_runtime_put_sync(&pdev->dev);
> > pm_runtime_disable(&pdev->dev);
> >
> > +err_of_parse:
> >
> > +err_cd_req:
> > clk_disable_unprepare(clk);
> > clk_put(clk);
> >
> > err_clk_get:
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-09-10 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 7:50 [PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add_host Xiang Wang
2014-07-16 9:53 ` Laurent Pinchart
2014-09-10 13:24 ` Laurent Pinchart [this message]
2014-09-10 13:56 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2073138.qpVRy5Xj3H@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=chris@printf.net \
--cc=cxie4@marvell.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=ulf.hansson@linaro.org \
--cc=wangx@marvell.com \
--cc=wangxfdu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox