From: Michael Neuling <mikey@neuling.org>
To: David Howells <dhowells@redhat.com>
Cc: stable@kernel.org, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org, Jeff Layton <jlayton@redhat.com>
Subject: [PATCH 2.6.32/stable] CIFS: Fix compile error with __init in cifs_init_dns_resolver() definition
Date: Wed, 04 Aug 2010 08:32:13 +1000 [thread overview]
Message-ID: <20749.1280874733@neuling.org> (raw)
In-Reply-To: <12482.1280871625@redhat.com>
In message <12482.1280871625@redhat.com> you wrote:
> Michael Neuling <mikey@neuling.org> wrote:
>
> > An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this error
> >
> > fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attrib
ute__' before 'cifs_init_dns_resolver'
> >
> > This removes the __init from cifs_init_dns_resolver()
>
> That's not really a good idea as the assembler may choose different pieces of
> assembly to do variable references and jumps, depending on the section
> information.
>
> A better fix is to add:
>
> #include <linux/module.h>
>
> to the header file.
Ok, new patch below.
CIFS: Fix compile error with __init in cifs_init_dns_resolver() definition
An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this error
fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'cifs_init_dns_resolver'
This adds the correct header file to fix this.
Signed-off-by: Michael Neuling <mikey@neuling.org>
cc: stable@kernel.org (for 2.6.32)
Index: linux-2.6-ozlabs/fs/cifs/dns_resolve.h
===================================================================
--- linux-2.6-ozlabs.orig/fs/cifs/dns_resolve.h
+++ linux-2.6-ozlabs/fs/cifs/dns_resolve.h
@@ -24,6 +24,8 @@
#define _DNS_RESOLVE_H
#ifdef __KERNEL__
+#include <linux/module.h>
+
extern int __init cifs_init_dns_resolver(void);
extern void cifs_exit_dns_resolver(void);
extern int dns_resolve_server_name_to_ip(const char *unc, char **ip_addr);
prev parent reply other threads:[~2010-08-03 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 5:03 [PATCH 2.6.32/stable] CIFS: Remove __exit mark from cifs_exit_dns_resolver() Michael Neuling
2010-08-03 5:03 ` [PATCH 2.6.32/stable] CIFS: Remove __exit mark from cifs_init_dns_resolver() header Michael Neuling
2010-08-03 21:40 ` David Howells
2010-08-03 22:32 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20749.1280874733@neuling.org \
--to=mikey@neuling.org \
--cc=dhowells@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox