The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Markus Pargmann <mpa@pengutronix.de>
To: Mikulas Patocka <mikulas@twibright.com>
Cc: Oleg Nesterov <oleg@redhat.com>, Christoph Hellwig <hch@lst.de>,
	nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: Warning when unloading network block device
Date: Wed, 20 Apr 2016 11:08:09 +0200	[thread overview]
Message-ID: <2076938.ix83ekSxsQ@adelgunde> (raw)
In-Reply-To: <alpine.DEB.2.02.1604151823510.23676@leontynka>

[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]

Hi,

On Friday 15 April 2016 18:30:32 Mikulas Patocka wrote:
> Hi
> 
> The patch 23272a6754b81ff6503e09c743bb4ceeeab39997 (nbd: Remove signal 
> usage) triggers a warning in nbd when the network block device is unloaded 
> - WARN_ON_ONCE(in_irq() || irqs_disabled()) in the function 
> __local_bh_enable_ip. The reason for the warning is that the function 
> kernel_sock_shutdown is called with interrupts disabled.

Thanks for reporting. Will post a patch soon.

Best Regards,

Markus

> 
> block nbd0: NBD_DISCONNECT
> block nbd0: shutting down socket
> ------------[ cut here ]------------
> WARNING: CPU: 10 PID: 11939 at kernel/softirq.c:150 __local_bh_enable_ip+0x66/0x90
> Call Trace:
>  [<ffffffff8122dde3>] ? dump_stack+0x46/0x63
>  [<ffffffff81050f57>] ? __warn+0xe7/0x100
>  [<ffffffff810555f6>] ? __local_bh_enable_ip+0x66/0x90
>  [<ffffffff813e2ddf>] ? inet_shutdown+0x3f/0x120
>  [<ffffffffa00693b0>] ? sock_shutdown+0x40/0x80 [nbd]
>  [<ffffffffa006a228>] ? __nbd_ioctl+0x5b8/0xa40 [nbd]
>  [<ffffffffa19cc169>] ? soft_cursor+0x169/0x1e6 [softcursor]
>  [<ffffffffa19e37ed>] ? bit_cursor+0x59d/0x5d0 [bitblit]
>  [<ffffffffa19e8801>] ? cursor_timer_handler+0x11/0x40 [fbcon]
>  [<ffffffff8108dd6d>] ? up+0xd/0x50
>  [<ffffffff81092ba6>] ? console_unlock+0x216/0x580
>  [<ffffffff8108c168>] ? remove_wait_queue+0x18/0x60
>  [<ffffffff812a6dca>] ? n_tty_write+0x24a/0x460
>  [<ffffffff811f7cec>] ? security_capable+0x3c/0x50
>  [<ffffffffa006a717>] ? nbd_ioctl+0x67/0x99 [nbd]
>  [<ffffffff8121d2d9>] ? blkdev_ioctl+0x649/0xa70
>  [<ffffffff81160c2e>] ? __vfs_write+0x1e/0xe0
>  [<ffffffff811789c2>] ? dput+0x42/0x2b0
>  [<ffffffff81199e14>] ? block_ioctl+0x34/0x40
>  [<ffffffff81174806>] ? do_vfs_ioctl+0x96/0x5b0
>  [<ffffffff81161c31>] ? vfs_write+0x131/0x190
>  [<ffffffff81174db1>] ? SyS_ioctl+0x91/0xa0
>  [<ffffffff81402e1f>] ? entry_SYSCALL_64_fastpath+0x17/0x93
> ---[ end trace 1956420c2e5f102b ]---
> block nbd0: Receive control failed (result -32)
> 
> Mikulas
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2016-04-20  9:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-15 16:30 Warning when unloading network block device Mikulas Patocka
2016-04-20  9:08 ` Markus Pargmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2076938.ix83ekSxsQ@adelgunde \
    --to=mpa@pengutronix.de \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikulas@twibright.com \
    --cc=nbd-general@lists.sourceforge.net \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox