From: "Heiko Stübner" <heiko@sntech.de>
To: Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@ziepe.ca>,
Steven Price <steven.price@arm.com>
Cc: Steven Price <steven.price@arm.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
John Keeping <john@metanate.com>
Subject: Re: [PATCH v4] iommu/rockchip: Add missing set_platform_dma_ops callback
Date: Fri, 31 Mar 2023 23:49:03 +0200 [thread overview]
Message-ID: <2077066.bB369e8A3T@diego> (raw)
In-Reply-To: <20230331095154.2671129-1-steven.price@arm.com>
Am Freitag, 31. März 2023, 11:51:54 CEST schrieb Steven Price:
> Similar to exynos, we need a set_platform_dma_ops() callback for proper
> operation on ARM 32 bit after recent changes in the IOMMU framework
> (detach ops removal). But also the use of a NULL domain is confusing.
>
> Rework the code to add support for IOMMU_DOMAIN_IDENTITY and a singleton
> rk_identity_domain which is assigned to domain when using an identity
> mapping rather than "detaching". This makes the code easier to reason about.
>
> Signed-off-by: Steven Price <steven.price@arm.com>
My knowledge of IOMMU magic is not that deep. Nevertheless I do believe
to mostly understand the change and the splats on my rk3288-pinky are gone
now with this patch:
Acked-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2023-03-31 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 9:51 [PATCH v4] iommu/rockchip: Add missing set_platform_dma_ops callback Steven Price
2023-03-31 21:49 ` Heiko Stübner [this message]
2023-04-13 9:51 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2077066.bB369e8A3T@diego \
--to=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=john@metanate.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox