Re: [PATCH v4] iommu/rockchip: Add missing set_platform_dma_ops callback

Joerg Roedel
2023-04-13T09:51:40Z

On Fri, Mar 31, 2023 at 10:51:54AM +0100, Steven Price wrote:
> Similar to exynos, we need a set_platform_dma_ops() callback for proper
> operation on ARM 32 bit after recent changes in the IOMMU framework
> (detach ops removal). But also the use of a NULL domain is confusing.
>
> Rework the code to add support for IOMMU_DOMAIN_IDENTITY and a singleton
> rk_identity_domain which is assigned to domain when using an identity
> mapping rather than "detaching". This makes the code easier to reason about.
>
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> Changes since v3[1]:
>
> * Added a dummy free callback to rk_identity_ops.
>
> [1] https://lore.kernel.org/r/20230330144604.2431436-1-steven.price%40arm.com
>
> drivers/iommu/rockchip-iommu.c | 61 ++++++++++++++++++++++++++--------
> 1 file changed, 47 insertions(+), 14 deletions(-)

Applied, thanks.