From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965636AbcIPUwu (ORCPT ); Fri, 16 Sep 2016 16:52:50 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:56098 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965467AbcIPUwl (ORCPT ); Fri, 16 Sep 2016 16:52:41 -0400 From: Arnd Bergmann To: tthayer@opensource.altera.com Cc: Rob Herring , gregkh@linuxfoundation.org, mark.rutland@arm.com, lftan@altera.com, jslaby@suse.com, peter@hurleysoftware.com, andriy.shevchenko@linux.intel.com, anton.wuerfel@fau.de, phillip.raffeck@fau.de, yegorslists@googlemail.com, matwey@sai.msu.ru, mail@maciej.szmigiero.name, peter.ujfalusi@ti.com, jonathanh@nvidia.com, dongsheng.wang@nxp.com, luis@debethencourt.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, tthayer.linux@gmail.com, nios2-dev@lists.rocketboards.org Subject: Re: [PATCH 2/4] serial: 8250: of: Load TX FIFO Load Size from DT Date: Fri, 16 Sep 2016 22:51:54 +0200 Message-ID: <2077078.euc60HfglH@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <2e79f6cc-8d9a-b9b7-884c-6916b2e74d64@opensource.altera.com> References: <1473351141-9239-1-git-send-email-tthayer@opensource.altera.com> <20160916192039.GB30710@rob-hp-laptop> <2e79f6cc-8d9a-b9b7-884c-6916b2e74d64@opensource.altera.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:kyF24ywINBbCa+ki6g27hmydwDgQrcDFZBMVSWRXmE5WCHjGmpq UlyGKf3jen+6jAdNho6R6MKfZlJK0kHH4qcv5IHj/HgbcyrqGOzlnUZhLbkJiLSu9aGjOh9 mOAR6YxSPVfxgZWVCR1wfx6XkJ1bey6UvFiv/dxjIYreDVXKKlWg4WBkllCHCEvnY1x6B/0 TUm7hWG8NciJDF1WJhdwA== X-UI-Out-Filterresults: notjunk:1;V01:K0:C+5BISeYvso=:sx+AwjhLIj8d90gGfEwfWj /X6PNfzKCZWrvWwOYfVaEIa1OKOrxjMxqtgoRctzXUKrNgYGKcQgg+7AKMNus08jA0e0y3HIc guWpFw1Yqsq5ReBlAXnQC7or3w8wsbLuj01nv34AaHhSld5GwYnxUej0PVkfthAE1JURt0CXd Wvd2zGicgef9IRJawT71qk93HahifDLpou/kW0nW/y+4HwBd9HXZ3e2LC+Tkauw14oQVS6eDo mNjA7zrWRJ5c13TofpAKMhFhtOIi8ilD1SVbGOAqv83AH4aSMYYG6TRRCPZ513AzGkAtOGCOu vKTCVsFZDpMxAqi4g43P7SvePHAnWL8uW1V8kl5TzsWnF+Iz4P1G5ibzDcz4TNFEKapVYPxCk WDAAxBJppRYfMdOZvn8cBmvEo+mKqJl/ox1ZQDB9rBhfvrluekp4Ver7Gwm1tQ0f9gzvpKBLE ISLD0m9AT2P8i9ox/Ma0oa9vjA+iJrRVeLtfx8rORvxVW9GiqMLqRHV50iuj/qyDjzG2M9wuH I7k0hJZwNrblVvNKAE192HosUZghQrzjnAIwlwfPgGUY4kYAJ41tu5XuTrcvVCgeSeQPOL50S wV1gUfaIMHwQoHvWeft3nHNcP1RcJs7Ydv5BISz2hjL+4ePKwm3UOKQdEqETIg5nBQavsFSxF aUjfZR00y5TYhrq+Frf7dP/fyWJJbkbtqVJaPuPqbAwY6Efjftkezgfd4SKAAdEFCKqhSurHW V5Pe3mUlLUEoSDll Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, September 16, 2016 3:52:55 PM CEST Thor Thayer wrote: > > > > > Yes, I originally had it implemented using that function but then I > realized the port8250.tx_loadsz is an unsigned int and therefore can > change size on different platforms. > > The assignment handles that. In retrospect, I should probably change > this to a of_property_read_u8() anyway so that it won't cause compile > warnings in the smaller architectures. > > Thank you for reviewing and the comments. We don't support architectures with 'int' types other than 32 bits, so the version that Rob suggested is guaranteed to work everywhere. Using u8 properties seems like a bad idea in general, better stay with 32-bit units for consistency. Arnd