From: Keith Owens <kaos@ocs.com.au>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linuxppc-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org
Subject: Re: 2.4.9-ac12 ppc ftr_fixup
Date: Mon, 27 Aug 2001 12:47:57 +1000 [thread overview]
Message-ID: <20783.998880477@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Sun, 26 Aug 2001 19:15:36 MST." <20010826191536.C1481@cpe-24-221-152-185.az.sprintbbd.net>
On Sun, 26 Aug 2001 19:15:36 -0700,
Tom Rini <trini@kernel.crashing.org> wrote:
>On Mon, Aug 27, 2001 at 10:27:22AM +1000, Keith Owens wrote:
>
>> 2.4.9-ac12 has new ppc code for CPU feature fixups. The ftr_fixup code
>> only handles entries that are built into the kernel. timex.h defines
>> get_cycles() using ftr_fixup and get_cycles() is used all over the
>> place, including in modules. AFAICT we need to add modutils support
>> for ftr_fixup.
>
>Er, eh? Excuse me if I'm being obtuse, but where is the problem? The fixup
>stuff is closely tied to bootup and what processor we happen to be on
>at the time. So we won't be trying to fixup any code in a module...
do_cpu_ftr_fixups() replaces unsupported code with NOP, based on the
table from __start___ftr_fixup to __stop___ftr_fixup which contains all
the data marked as section(__ftr_fixup). Fine, but it only handles
section __ftr_fixup data in the kernel, it does not write NOP over
__ftr_fixup data in modules. So any code marked as section __ftr_fixup
in a module executes unchanged. Unless I am missing something, that is
a problem.
next prev parent reply other threads:[~2001-08-27 2:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-27 0:27 2.4.9-ac12 ppc ftr_fixup Keith Owens
2001-08-27 2:15 ` Tom Rini
2001-08-27 2:47 ` Keith Owens [this message]
2001-08-27 2:54 ` Tom Rini
2001-08-27 3:07 ` Keith Owens
2001-08-27 7:39 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20783.998880477@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox