From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 26 Aug 2001 22:48:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 26 Aug 2001 22:48:14 -0400 Received: from zok.SGI.COM ([204.94.215.101]:6869 "EHLO zok.sgi.com") by vger.kernel.org with ESMTP id ; Sun, 26 Aug 2001 22:48:03 -0400 X-Mailer: exmh version 2.1.1 10/15/1999 From: Keith Owens To: Tom Rini cc: Alan Cox , linuxppc-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org Subject: Re: 2.4.9-ac12 ppc ftr_fixup In-Reply-To: Your message of "Sun, 26 Aug 2001 19:15:36 MST." <20010826191536.C1481@cpe-24-221-152-185.az.sprintbbd.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 27 Aug 2001 12:47:57 +1000 Message-ID: <20783.998880477@kao2.melbourne.sgi.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Aug 2001 19:15:36 -0700, Tom Rini wrote: >On Mon, Aug 27, 2001 at 10:27:22AM +1000, Keith Owens wrote: > >> 2.4.9-ac12 has new ppc code for CPU feature fixups. The ftr_fixup code >> only handles entries that are built into the kernel. timex.h defines >> get_cycles() using ftr_fixup and get_cycles() is used all over the >> place, including in modules. AFAICT we need to add modutils support >> for ftr_fixup. > >Er, eh? Excuse me if I'm being obtuse, but where is the problem? The fixup >stuff is closely tied to bootup and what processor we happen to be on >at the time. So we won't be trying to fixup any code in a module... do_cpu_ftr_fixups() replaces unsupported code with NOP, based on the table from __start___ftr_fixup to __stop___ftr_fixup which contains all the data marked as section(__ftr_fixup). Fine, but it only handles section __ftr_fixup data in the kernel, it does not write NOP over __ftr_fixup data in modules. So any code marked as section __ftr_fixup in a module executes unchanged. Unless I am missing something, that is a problem.