Re: [PATCH 1/4] Staging: rtl8192e: Remove variable bFirstSeg

Dan Carpenter
2023-12-11T08:37:20Z

On Sun, Dec 10, 2023 at 11:37:02AM -0800, Tree Davies wrote:
> Remove variable bFirstSeg as it is defined but never used.
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> ---
> drivers/staging/rtl8192e/rtllib.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 0a8c44e497f5..c0a24826cd3b 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -103,7 +103,6 @@ struct cb_desc {
> /* Tx Desc Related flags (8-9) */
> u8 bLastIniPkt:1;
> u8 bCmdOrInit:1;
> - u8 bFirstSeg:1;
> u8 bLastSeg:1;
> u8 bEncrypt:1;
> u8 tx_dis_rate_fallback:1;

I don't think you can remove these. They're part of the protocol for
talking to the firmware.

regards,
dan carpenter