From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4025F33F58C for ; Tue, 21 Apr 2026 20:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776805150; cv=none; b=LoKrFnQNR3+y6NIq4l/ol2A7Mxm0LNoX83sd003by1TNF3A9JfmXWAX+TB3tcrfxvmcCFxcCyWdjlJomi/mcU69KDpYcwsr6ZZgh7EavMfE4hy8J3NQMlG7pIN9EPTbPUp+8p5eQFDDdrhm7qNsHY+AuI70mejp9HfmzxdkA6gM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776805150; c=relaxed/simple; bh=VC8AY93lihS6pHsZUAz/pZ8VolrI50ool0waQtLSc44=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=QADAIdNMzrWyDS0dVKKbxt3n6A5h0o/f/idbSM0xKmtqZTtEpTc1fWIwxr5uBZxin/PJP18rCtpGbR7fwGMwjL80Da/j5qLftU+yy9a0dLn7kbGBmUZZ1xK7u/u6lkCpk7yW4D0GM7C2rbB5aWpsWgQYPwfpArPs4oT9wQ3dcwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GNmQNJsT; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GNmQNJsT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776805148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VC8AY93lihS6pHsZUAz/pZ8VolrI50ool0waQtLSc44=; b=GNmQNJsTmKMGNt5bwUMFWktZYr3UxYJx+1mvCCHDNc/XUD5HBvfujOBgbE5nYJ9ZZ7dHgn IcbfsJQ9BQ88d0pUmw/ewndDXiohA3knnm7p+ljKIDIn+ZAJe5pS+1Yo3v806VoJwencT7 46acarrfG8gPSCZsk9HLy3uT9IZpylA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-711-qSDvEMwUP7uWKhfPaaC7hA-1; Tue, 21 Apr 2026 16:59:05 -0400 X-MC-Unique: qSDvEMwUP7uWKhfPaaC7hA-1 X-Mimecast-MFC-AGG-ID: qSDvEMwUP7uWKhfPaaC7hA_1776805143 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C1C311956055; Tue, 21 Apr 2026 20:59:02 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.48.17]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5F25D1800351; Tue, 21 Apr 2026 20:58:58 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20260421203833.745240-1-horms@kernel.org> References: <20260421203833.745240-1-horms@kernel.org> <20260420145900.1223732-3-dhowells@redhat.com> To: Simon Horman Cc: dhowells@redhat.com, netdev@vger.kernel.org, marc.dionne@auristor.com, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, jaltman@auristor.com, stable@kernel.org Subject: Re: [PATCH net 2/4] rxrpc: Fix conn-level packet handling to unshare RESPONSE packets Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2080439.1776805136.1@warthog.procyon.org.uk> Date: Tue, 21 Apr 2026 21:58:56 +0100 Message-ID: <2080440.1776805136@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Simon Horman wrote: > This isn't a new bug introduced by this patch, but since we are modifying > the unshare path here: when rxrpc_unshare_skb() fails, it sets *_skb = NULL > and returns just_discard. Is there a way to avoid having skb_unshare() eat your ref to the source skbuff if it fails? David