From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7BB8451069 for ; Thu, 7 May 2026 18:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778179160; cv=none; b=JNfXelZYBHjq834f0YnbFhZu+hwPIXCgNVlenBM9usNNiF8QgN4a+Vh428Fx9EpB/G4zVaDGSRo+jIac84iUs/D6ege5i6vRmDAAp89XKFJUgwY6daxp8KzDrR8u6SHJ2/sHszcm5+rcSNvVZ+zl+Cv4kB4eakiMtvIpWYcPb2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778179160; c=relaxed/simple; bh=f/VYt86QfsV33lO5nWhjommtwvlcryeqI+nt7Vqb76c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ts/rMptovNoPkppczk2MbekEVbEiMyrgJF7FWa01fDAMJaN6BA9JEv3RiXM5x3bTh8HuG8Wu4TXJ0EG7PnsXKrRhRgevixLg77UIM57spHwMZ3Ftg6uPZnApET1iwq0Ovn+0ol90zho0qi1cnyXws98SWUd9aX6whIHDXpYDpDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=sETjafTP; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="sETjafTP" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-8d7e7f48499so128910885a.1 for ; Thu, 07 May 2026 11:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1778179158; x=1778783958; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xAxf1DNF2nC8sz42taPRq/pgsGcKQpqrWaLh7UNAXF0=; b=sETjafTPdUg2ii93kH2SRdQpxIDwlHw++/Udnl0YvFhjKxo3mfpZymbm3zCbgKWwy1 ZZTG/CwjDVG41bxom74SCHnJU+/7a9q6J2hC8o83bgco6Dr+7ETgR8oAhevz4ocMQDFX Ljcf7sSF83yMY1IdGcMdSDhhLa5F4ccPXRZr9o4kt7J8RlHc4eMCYebqQvQRTxtJPweY CbSHWFRgCs3jlhl7Ba3jBV+nkiOcv778l8CV5M7TCIdT8z5yhZMO1VXKgy2ghAU+ztSA rPjKoKJOaL9XsTVzUnI29jx+V0ofMTZcgeaBGW+QSjNrvNhH5sSNkCxFd4FPz2sDDIiR oyMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778179158; x=1778783958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xAxf1DNF2nC8sz42taPRq/pgsGcKQpqrWaLh7UNAXF0=; b=pzX0Yagp/N8YYrcch+y9Gobef6PsvF7wOKzg9IoSyIjYGK8EWr+qX3hRPzHcsfJxtw NGwf5uBczXoqDmmNX+eelIasSYlO6eh9U3ybd5Ah+t0N+FapdNCiglb5tbarP7D6Ybln 6X6mThjH5Z/LQN0gv+pGnO9U9TIL2dxfVwu6lEJ5Um1ecNpUGu1tFPNxVNOveKrcJ5LU crVor9oVFY4DCvgHWMyi8r67y6nDjSN79Hv5NmFHhZu8qhDfqCJ4Q1lK4z5qsmPdN5zN nK+sLLSouPm5dC9ln0UeVSkXa2KXNCVslqchuoCOUj64Y/bSaowA4Yyf+dO6KjyLF+TL frBg== X-Forwarded-Encrypted: i=1; AFNElJ9Sspmm7YPWd0aXsq0SseBkQ6HVehE7Cfrw3HpQj2SXPr//U2oMiB2jxf428P3H/TutJt/Tuh4ZoNOJbZM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2khHQ1YFa+OOwOl8c2aWx5QZmTVhAevjU16JhNg598gNyRZ+4 J7APqAoTKxsoQC/fHPq24yW9rLIst8kTHxkIZ5cvYpwy94YoUAWFhjSohII+AOxWZpU= X-Gm-Gg: AeBDietVyQNUVg/OfoxystZHIXgE1bieJGro6amhao7eBKfyTa43N1FfyhYiQL3CJNP Fhf9uq22fVDnosiAb3GRnqmL+0m9/Cb63bmQXLkUz3VrCh/JPJK5PXjtnUDlywhu1DhLZ/vBIR3 Vk4XpkQnotc2ixNEcsw7jd3mV9FLcN85DV3VegfzLpmAmUwj1AZ2nFe5G2Ebqq+ILFNAKOTfdKj fhijWICH2JlDqRP1yi0TPhmxMe9SNmQyhIg8Gorjd4GBTKS8gys6ZTjRfq/Qzyi6yCxrZiaJ9ms sFUcph314TKwpqRk6b3ThvREA30UbdtQO3A9W6lXaQi8Daf5fZ/705Mh+52oxVHFcxVubTu6iFP TcxU/d3kTuY3mNBI163+8Ws4apvPYe7aZZsysbGPHWZpGqBQO3kV/I+jArWGUP9cMUXGgOxn+BH laiyIAvKAZuU818WvmEtSb6vdSeMXhMEIkJdCEG8UA2LhC45Bk1OqLbxQPJiaa4aVP X-Received: by 2002:a05:620a:40c9:b0:8e9:13ea:a0e1 with SMTP id af79cd13be357-904d496d4abmr1387402085a.18.1778179157638; Thu, 07 May 2026 11:39:17 -0700 (PDT) Received: from [172.22.22.234] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc2c25324esm2298627185a.23.2026.05.07.11.39.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 11:39:17 -0700 (PDT) Message-ID: <20903580-85af-4e7b-b3dc-b8de49bd32c1@riscstar.com> Date: Thu, 7 May 2026 13:39:13 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 09/12] gpio: tc956x: add TC956x/QPS615 support To: Andrew Lunn Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-10-elder@riscstar.com> <736fb3b7-c88a-4ec4-96ad-d1b79cc48d30@lunn.ch> <30cec7dd-ac3c-47ab-896a-c29992bd5ba5@riscstar.com> <3e5a42cc-53b8-4065-a32a-d754be40b4c7@lunn.ch> Content-Language: en-US From: Alex Elder In-Reply-To: <3e5a42cc-53b8-4065-a32a-d754be40b4c7@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/2/26 9:48 PM, Andrew Lunn wrote: >> It's possible gpio-regmap.c *could* be used. We started with >> vendor code and this code got separated at some point along >> the way. It was working, and I don't think I pursued other >> options at that point. I'll look at this possibility before we >> send out the next version. > > The GPIO subsystem has made a big effort to provide generic code, > since GPIOs are pretty simple things with a lot in common. So if the > generic code works, or can be made to work with minor changes, you > should use it. Yes, I can confirm this is what I will use. As mentioned elsewhere, LinusW provided a patch that support the one unusual thing this does (input-only GPIO lines). >> What do you mean instantiate it twice? > > I _think_ you need one instance for the first 32 GPIOs, and a second > one for the remaining GPIOs. But maybe config->reg_stride might allow > it to work with a single instance? Oh I see. Looking at it now, I presume the reg_stride will work here. Thanks. -Alex > Andrew