From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752998AbcGOIlm (ORCPT ); Fri, 15 Jul 2016 04:41:42 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:63235 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbcGOIlj (ORCPT ); Fri, 15 Jul 2016 04:41:39 -0400 From: Arnd Bergmann To: Dongpo Li Cc: f.fainelli@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, frowand.list@gmail.com, davem@davemloft.net, andrew@lunn.ch, xuejiancheng@hisilicon.com, benjamin.chenhao@hisilicon.com, howell.yang@hisilicon.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/3] Add Hisilicon MDIO bus driver and FEMAC driver Date: Fri, 15 Jul 2016 10:41:07 +0200 Message-ID: <20917223.X0KrqBAbxT@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1468571195-59763-1-git-send-email-lidongpo@hisilicon.com> References: <1468571195-59763-1-git-send-email-lidongpo@hisilicon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:RGRwG/Seko9QSKSakMsiEaYw9mxbFJtFdoASJfaQHjlxznN0/xa 18O5D4VebbBcFX5Sz+q26kLJOLC5N1T+QT52TVeaUIVGQR9uBnyF+gVv+343WBvU+Fc3Bys 0k84xiOBQ6e9GPhbdoE5I4Y35snHxmyULZsmHNqvgKPWj0K2h4SvZevkp0xniNUAH4i/oZr O6J1wTplOmzjXn8aI4jDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:98X6aJDAP/k=:nvYdKrB7ZbHck/oYb9lbhL 3SWFFoK9S6dxfvzTkRgurnewm3J0Rpr/4xmz2FW/9ABSRxSGgM67VdrCpLnTaRO8zq7Mll6Fg 3CrHiExcvwrf7VpnZ+PfTfUlWZcqrhTrbGJRhq9fn4/rUSgRSHg51O1VP02PJY17uqnPwyKMd dCkh9SNWFpeMZHPZafVFFqJZ9El4mp69z7F0LlUKi+qjSfGCO1ka+AlfANoVE8+h/FahbKxs6 2JZzFQij3OQwbn9OBw2qbxX75UQ2ova67ckiDq+q5y3+R0MhX3wfVgh4mEozLNC2t0IJpHANK NjLei/HNGUSOvoNqBbbzDoxUi7O8euX3/J6Z1/fOgqsgObEydJ7iilq8dSAdPyDl75olLoMn/ v8i9TsjDJibmU6h4LX9qyF/nFGuEqTOQoRn8IWlNbx8CYKc9kabnOQV6T9Iw6XEaYllm2pLOA CbJjejMeyY5Koe444BYAHbTV8GtFORKn6OZkdjQXywDGGslk3j+rl6v0aL5IS0fzQwNVlGzEg +3I7KDziaWlePTE6jadOEYhChsDKoJkIMc5cJbRMiapTg3ZD8U4GlBgUywgAGxtWhG+XePUPa Q6s5OTKj0LaSQPYcu44ZhZWuXDmyeZOJIIZXr+gvpeuJolbra2EhMJHYwag7fJZN4BjjAuuLL fJ8zvgD9hAWbzVE6wzMPocRPMth+MCFIW26S92Rpb4YYoSClqYGnlev5z8IPTf0+i9ZKjTadT I0dprMpEAKVlvgK9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, July 15, 2016 4:26:32 PM CEST Dongpo Li wrote: > This patch set adds a Hisilicon MDIO bus driver and > a Fast Ethernet MAC(FEMAC) driver. > We also abstract a general interface "of_phy_get_and_connect" > for PHY connect. User will have no bother with getting > "phy-mode" and "phy-handle" any more. > > Changes in v1: > - Pass private data structure instead of struct mii_bus > in MDIO read and write operation. > - Return the error which devm_clk_get() gives when MDIO probe. > - Leave the clock unprepared and disabled on error when MDIO probe. > - Abstract a general interface "of_phy_get_and_connect" for PHY connect. > - Remove the "_reset" suffixes in "reset-names" property. > - Enable tx per-packet interrupt when tx fifo full. > - Remove pointless compatible and add SoC specific compatible. > - Declare only one clock in MAC dts documentation. > - Add standard unit suffixes for "phy-reset-delays". > - Use a smaller NAPI poll weight 16 for our Fast Ethernet MAC. > - Use phy_ethtool_{get|set}_link_ksettings for ethtool ops. > - Use phydev from struct net_device in MAC driver. > Looks all good to me now, Reviewed-by: Arnd Bergmann One comment on the submission format: we normally count the initial submission as "v1", so after [PATCH 0/3], the following version is [PATCH v2 0/3], not [PATCH v1 0/3]. No need to re-send for this now, and if you end up having to make other changes, just continue with "v2" for this driver, just follow the normal scheme if you send another driver. Arnd