Re: [RFC PATCH 0/6] Convert mount_single-using filesystems to fs_context

Richard Weinberger
2019-03-21T16:34:45Z

Am Donnerstag, 21. März 2019, 16:45:02 CET schrieb David Howells:
> Richard Weinberger <richard@nod.at> wrote:
>
> > > Bah. The problem is that vfs_get_super() doesn't set fc->root before
> > > calling reconfigure_super().
> >
> > Do you still need the disassembly?
>
> Thanks, but no. I've pushed replacement patches to my git branch.

Just gave it a try, jffs2 does not mount anymore. The problem is that you define
an Opt_source in super.c, but never evaluate it -> jffs2_parse_param() returns
-EINVAL.

What I really don't get is the new logging stuff in include/linux/fs_context.h.
printk() is already an overloaded beat, why another layer?

The log output seems very odd to me:
[ 13.117593] e MTD: Couldn't look up '/dev/mtd0': -15

Please notice the "e" before MTD, first I though this is a memory
corruption, but is your log level?!

Thanks,
//richard