From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57F9C3876BD for ; Thu, 16 Jul 2026 04:59:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784177956; cv=none; b=ATfr1DKFNmGgpDp1psSBfGmj63vZxeRv92nBJUIs8p24H5G0tzpCJ+zsx36N+pOn4MGx4oUzdPSJAN0OxAVIWBTvlbrN0W4iw/2z5YUYG4sHYoZZwOAgheLe8QPoyOFMhMZ3l/xjHuJk2oR+bsFnbwPBp23OlNcF/2Qok2lbDzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784177956; c=relaxed/simple; bh=Q+OtUgkTLjMviwdPjO6dyXit9l1yGqWak2Q+ZgX/A2k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lxtp6liA6xN9Qi+TujIApIJO0r8x8JjjRfoSySvX6F8sGsO8Xnq/pNNK6IxBldv2OZz2CaYXDiqh3KTD7IlP64eZcQtxEhNU5/G0XoL2DJ975qSaCPGuhYwq0mfX4eG3Wu5mGAsS7tsviUS0wddJY1ruit6ZTIXFoyELsMlWr5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=luh4BpEt; arc=none smtp.client-ip=95.215.58.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="luh4BpEt" Message-ID: <20a444b2-aeed-4af8-ba76-e994e2c14087@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784177940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rvCD2v4AruZcFU070q9xEZedJW9EMLvMy6qcn3WXYx0=; b=luh4BpEt1Vw63yLxuktf95I3AsZECoA/3XL1SK8XHWRUNP1/s75dQxFU65jkP25Ml5WQGm kZLGW9kereDgs6y9UTClpfQKSlz8AYCYSFOpJj6TRW4Mh6P60GIxUe0J0Ipo+MP1BM2MEu V4Bz5j4yq4bkv5IBJBk6AsywIkRiBVE= Date: Thu, 16 Jul 2026 12:58:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next] bpf:syscall: Log error code on trampoline unlink failure To: xu.xin16@zte.com.cn, ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Cc: xu.xin@linux.dev References: <20260716113419588y6Ycmo7pzva8buwne9yWZ@zte.com.cn> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Leon Hwang Content-Language: en-US In-Reply-To: <20260716113419588y6Ycmo7pzva8buwne9yWZ@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT In subject, 'bpf:' is enough, 'syscall:' can be dropped. On 16/7/26 11:34, xu.xin16@zte.com.cn wrote: > From: xu xin > > Replace silent WARN_ON_ONCE with WARN_ONCE that prints the actual error > code from bpf_trampoline_unlink_prog(). This aids debugging of race > conditions during link teardown, while keeping the warning rate limited > to avoid log flooding. Have you tried to trace bpf_trampoline_unlink_prog() with fexit? bpftrace -lv 'fexit:bpf_trampoline_unlink_prog' kretfunc:vmlinux:bpf_trampoline_unlink_prog struct bpf_tramp_node * node struct bpf_trampoline * tr struct bpf_prog * tgt_prog int retval Since bpf_trampoline_unlink_prog() can be traced with fexit, it seems unnecessary for this change? Thanks, Leon > [...]