public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tao Chen <chen.dylane@gmail.com>
To: Eduard Zingerman <eddyz87@gmail.com>,
	ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	haoluo@google.com, jolsa@kernel.org, qmo@kernel.org
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 0/2] Add prog_kfunc feature probe
Date: Fri, 24 Jan 2025 10:49:14 +0800	[thread overview]
Message-ID: <20ad3071-2140-470e-90c0-96fc8f74ff2d@gmail.com> (raw)
In-Reply-To: <3955701be6b7f068d50a5bef2bbe74b97e285621.camel@gmail.com>

在 2025/1/24 08:42, Eduard Zingerman 写道:
> On Fri, 2025-01-24 at 01:05 +0800, Tao Chen wrote:
>> More and more kfunc functions are being added to the kernel.
>> Different prog types have different restrictions when using kfunc.
>> Therefore, prog_kfunc probe is added to check whether it is supported,
>> and the use of this api will be added to bpftool later.
>>
>> Change list:
>> - v1 -> v2:
>>    - check unsupported prog type like probe_bpf_helper
>>    - add off parameter for module btf
>>    - chenk verifier info when kfunc id invalid
>>
>> Revisions:
>> - v1
>>    https://lore.kernel.org/bpf/20250122171359.232791-1-chen.dylane@gmail.com
>>
>> Tao Chen (2):
>>    libbpf: Add libbpf_probe_bpf_kfunc API
>>    selftests/bpf: Add libbpf_probe_bpf_kfunc API selftests
>>
>>   tools/lib/bpf/libbpf.h                        | 17 ++++++-
>>   tools/lib/bpf/libbpf.map                      |  1 +
>>   tools/lib/bpf/libbpf_probes.c                 | 47 +++++++++++++++++++
>>   .../selftests/bpf/prog_tests/libbpf_probes.c  | 35 ++++++++++++++
>>   4 files changed, 99 insertions(+), 1 deletion(-)
>>
> 
> Hi Tao,
> 
> Looks like something is wrong with the way the patch was generated:
> - patchwork link:
>    https://patchwork.kernel.org/project/netdevbpf/patch/20250123170555.291896-2-chen.dylane@gmail.com/
> - error message:
>    https://github.com/kernel-patches/bpf/pull/8395
> 
>      Cmd('git') failed due to: exit code(128)
>        cmdline: git am --3way
>        stdout: 'Applying: libbpf: Add libbpf_probe_bpf_kfunc API
>      Patch failed at 0001 libbpf: Add libbpf_probe_bpf_kfunc API
>      When you have resolved this problem, run "git am --continue".
>      If you prefer to skip this patch, run "git am --skip" instead.
>      To restore the original branch and stop patching, run "git am --abort".'
>        stderr: 'error: corrupt patch at line 103
>      error: could not build fake ancestor
>      hint: Use 'git am --show-current-patch=diff' to see the failed patch'
> 
> I get the same error when trying to apply locally,
> could you please double check?
> 
> Thanks,
> Eduard
> 

Hi, Eduard, thank you for your reply, i tried it out, and it turns out 
it's really my problem. I will resend it in v3.

-- 
Best Regards
Dylane Chen

  reply	other threads:[~2025-01-24  2:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 17:05 [PATCH bpf-next v2 0/2] Add prog_kfunc feature probe Tao Chen
2025-01-23 17:05 ` [PATCH bpf-next v2 1/2] libbpf: Add libbpf_probe_bpf_kfunc API Tao Chen
2025-01-24  1:34   ` Eduard Zingerman
2025-01-24  3:25     ` Tao Chen
2025-01-23 17:05 ` [PATCH bpf-next v2 2/2] selftests/bpf: Add libbpf_probe_bpf_kfunc API selftests Tao Chen
2025-01-24  0:42 ` [PATCH bpf-next v2 0/2] Add prog_kfunc feature probe Eduard Zingerman
2025-01-24  2:49   ` Tao Chen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-01-23 16:55 Tao Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20ad3071-2140-470e-90c0-96fc8f74ff2d@gmail.com \
    --to=chen.dylane@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qmo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox