From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800AbcKQTO5 (ORCPT ); Thu, 17 Nov 2016 14:14:57 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33657 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbcKQTOz (ORCPT ); Thu, 17 Nov 2016 14:14:55 -0500 Subject: Re: [PATCH] sound: Add dependency on DMA To: Takashi Iwai References: <20161117185237.7070-1-f.fainelli@gmail.com> Cc: linux-kernel@vger.kernel.org, "moderated list:SOUND" , arnd@arndb.de, Jaroslav Kysela From: Florian Fainelli Message-ID: <20c84fff-13d0-e608-1237-6bc567014cc5@gmail.com> Date: Thu, 17 Nov 2016 11:14:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/2016 11:03 AM, Takashi Iwai wrote: > On Thu, 17 Nov 2016 19:52:37 +0100, > Florian Fainelli wrote: >> >> Architectures like m32r do not have a proper DMA-API implementation, >> fixes COMPILE_TEST linking failures for the sounds subsystem. > > What error did you get exactly? > There are already CONFIG_HAS_DMA dependency in a few places, so I > wonder what's missing. They looked like these: sound/built-in.o: In function `snd_pcm_lib_default_mmap': (.text+0xbb14): undefined reference to `bad_dma_ops' sound/built-in.o: In function `snd_pcm_lib_default_mmap': (.text+0xbb1c): undefined reference to `bad_dma_ops' sound/built-in.o: In function `snd_pcm_lib_default_mmap': (.text+0xbb34): undefined reference to `dma_common_mmap' sound/built-in.o: In function `snd_pcm_lib_default_mmap': (.text+0xbb34): relocation truncated to fit: R_M32R_26_PCREL_RELA against undefined symbol `dma_common_mmap' Makefile:961: recipe for target 'vmlinux' failed I could probably add an ifdef CONFIG_HAS_DMA just surrounding these snd_pcm_lib if you think this is more appropriate? -- Florian