Re: [PATCH 1/3] iio: adc: ina3221: Add DT binding details

Laxman Dewangan
2016-06-03T12:34:39Z

On Friday 03 June 2016 05:41 PM, Jonathan Cameron wrote:
> On 03/06/16 12:48, Laxman Dewangan wrote:
>> On Friday 03 June 2016 03:49 PM, Jonathan Cameron wrote:
>>>>> +
>>>>> +enable-power-monitor: Boolean, Enable power monitoring of the device.
>>> Is this the power good stuff? description should be more detailed.
>> If there is no shunt resistance then we can not enable power monitor
>> on that rail. Device does not mandate to have shunt and so this is
>> based on platforms.
> The voltage shunt also becomes meaningless (unless you have other very
> small voltage drops to measure!). So drop that channel as well.
> Either it is there to do current measurement or it isn't.

OK. understood.

>>>>> +
>>>>> +enable-continuous-mode: Boolean. Device support oneshot and continuous
>>>>> + mode for the channel data conversion. Presence
>>>>> + of this property will enable the continuous
>>>>> + mode from boot.
>>> Is the difference between driver load time and the point where usespace can
>>> set it up significant enough to justify this?
>> We change the mode dynamically. If we have more core then goto the
>> continuous mode so that we can apply throttling if power consumption
>> is going more than requirement. If we are running single core then
>> change to oneshot mode.
> That's definitely a usespace or firmware decision, not a kernel one
> to my mind - unless I guess you an enforcing bringing this device up
> before firing up the additional cores?
>
> Then it's nasty but I can start to see some justification.

Yaah, this is FW decision. Our need on some platform was that start the
driver with the continuous mode.
But I think that may be specific need. I can remove this and let user
space can enable the continuous mode.