Re: [PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

Jonathan Cameron
2016-06-03T12:04:59Z

On 03/06/16 12:31, Laxman Dewangan wrote:
>
> On Friday 03 June 2016 03:46 PM, Jonathan Cameron wrote:
>> On 03/06/16 11:06, Jonathan Cameron wrote:
>>>
>>> Code looks good, bu these more fundamental bits need sorting.
>> Another minor point - why do the power calculations in driver?
>> no hardware support for it, so why not just leave it to userspace?
>
> Device supports the bus and shunt voltage monitoring. So even no current. Also the warning/critical limit is for the voltage across shunt.
>
> So should we only expose the shunt/bus voltage, no power/current?
>
> I am thinking that user space should not know the platform and hence shunt resistance and so exposing the current and power on bus is better option.
>
I'd go for current and voltage rather than current and power, but
otherwise agree.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html