From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev,
David Kershner <david.kershner@unisys.com>,
sparmaintainer@unisys.com
Subject: Re: [PATCH v2] staging: Remove the drivers for the Unisys s-Par
Date: Thu, 14 Apr 2022 10:40:26 +0200 [thread overview]
Message-ID: <2100119.irdbgypaU6@leap> (raw)
In-Reply-To: <YlfJ1UQQQeYBvTHV@kroah.com>
On gioved? 14 aprile 2022 09:14:29 CEST Greg Kroah-Hartman wrote:
> On Wed, Apr 13, 2022 at 10:01:11AM +0200, Fabio M. De Francesco wrote:
> > The Unisys sub-tree contains three drivers for the "Unisys Secure
Partition"
> > (s-Par(R)): visorhba, visorinput, visornic.
> >
> > They have no maintainers, in fact the only one that is listed in
MAINTAINERS
> > has an unreacheable email address. During 2021 and 2022 several patches
have
> > been submitted to these drivers but nobody at Unisys cared of reviewing
the
> > changes. Probably, also the "sparmaintainer" internal list of
unisys.com is
> > not anymore read by interested Unisys' engineers.
> >
> > Therefore, remove the ./unisys subdirectory and delete the relevant
entries
> > in the MAINTAINERS, Kconfig, Makefile files.
> >
> > Cc: David Kershner <david.kershner@unisys.com>
> > Cc: sparmaintainer@unisys.com
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> > ---
> >
> > v1->v2: Add two "Cc:" lines, one to David Kershner and the second to
the
> > "sparmaintainer" list at unisys.com, as requested by Greg Kroah-
Hartman.
> >
> > MAINTAINERS | 8 -
> > drivers/staging/Kconfig | 2 -
> > drivers/staging/Makefile | 1 -
> > .../ABI/sysfs-platform-visorchipset | 89 -
> > .../staging/unisys/Documentation/overview.txt | 337 ---
> > drivers/staging/unisys/Kconfig | 16 -
> > drivers/staging/unisys/MAINTAINERS | 5 -
> > drivers/staging/unisys/Makefile | 7 -
> > drivers/staging/unisys/TODO | 16 -
> > drivers/staging/unisys/include/iochannel.h | 571 -----
> > drivers/staging/unisys/visorhba/Kconfig | 15 -
> > drivers/staging/unisys/visorhba/Makefile | 10 -
> > .../staging/unisys/visorhba/visorhba_main.c | 1142 ---------
> > drivers/staging/unisys/visorinput/Kconfig | 16 -
> > drivers/staging/unisys/visorinput/Makefile | 7 -
> > .../staging/unisys/visorinput/visorinput.c | 788 ------
> > drivers/staging/unisys/visornic/Kconfig | 16 -
> > drivers/staging/unisys/visornic/Makefile | 10 -
> > .../staging/unisys/visornic/visornic_main.c | 2131 -----------------
>
>
>
> > 19 files changed, 5187 deletions(-)
> > delete mode 100644 drivers/staging/unisys/Documentation/ABI/sysfs-
platform-visorchipset
> > delete mode 100644 drivers/staging/unisys/Documentation/overview.txt
> > delete mode 100644 drivers/staging/unisys/Kconfig
> > delete mode 100644 drivers/staging/unisys/MAINTAINERS
> > delete mode 100644 drivers/staging/unisys/Makefile
> > delete mode 100644 drivers/staging/unisys/TODO
> > delete mode 100644 drivers/staging/unisys/include/iochannel.h
> > delete mode 100644 drivers/staging/unisys/visorhba/Kconfig
> > delete mode 100644 drivers/staging/unisys/visorhba/Makefile
> > delete mode 100644 drivers/staging/unisys/visorhba/visorhba_main.c
> > delete mode 100644 drivers/staging/unisys/visorinput/Kconfig
> > delete mode 100644 drivers/staging/unisys/visorinput/Makefile
> > delete mode 100644 drivers/staging/unisys/visorinput/visorinput.c
> > delete mode 100644 drivers/staging/unisys/visornic/Kconfig
> > delete mode 100644 drivers/staging/unisys/visornic/Makefile
> > delete mode 100644 drivers/staging/unisys/visornic/visornic_main.c
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3ed62dcd144e..a62da6d0f943 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -20183,14 +20183,6 @@ F: drivers/cdrom/cdrom.c
> > F: include/linux/cdrom.h
> > F: include/uapi/linux/cdrom.h
> >
> > -UNISYS S-PAR DRIVERS
> > -M: David Kershner <david.kershner@unisys.com>
> > -L: sparmaintainer@unisys.com (Unisys internal)
> > -S: Supported
> > -F: drivers/staging/unisys/
> > -F: drivers/visorbus/
>
> You forgot to delete the files in this directory as well :(
>
Sorry, that's worse than just being forgetful. I did not carefully read the
lines I deleted in MAINTAINERS :(
I will post a v3 soon. In the meantime, I'll also add between the lines
"Cc:" that other person that Alison found in drivers/staging/unisys/TODO.
Thanks,
Fabio M. De Francesco
prev parent reply other threads:[~2022-04-14 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 8:01 [PATCH v2] staging: Remove the drivers for the Unisys s-Par Fabio M. De Francesco
2022-04-14 7:14 ` Greg Kroah-Hartman
2022-04-14 8:40 ` Fabio M. De Francesco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2100119.irdbgypaU6@leap \
--to=fmdefrancesco@gmail.com \
--cc=david.kershner@unisys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox