Re: [PATCH/RFC] msleep() with hrtimers

Roman Zippel
2007-07-16T11:39:35Z

Hi,

On Sun, 15 Jul 2007, Jonathan Corbet wrote:

> Here's another approach: a reimplementation of msleep() and
> msleep_interruptible() using hrtimers. On a system without real
> hrtimers this code will at least drop down to single-jiffy delays much
> of the time (though not deterministically so). On my x86_64 system with
> Thomas's hrtimer/dyntick patch applied, msleep(1) gives almost exactly
> what was asked for.

One possible problem here is that setting up that timer can be
considerably more expensive, for a relative timer you have to read the
current time, which can be quite expensive (e.g. your machine now uses the
PIT timer, because TSC was deemed unstable).
One question here would be, is it really a problem to sleep a little more?
Another possibility would be to add another sleep function, which uses
hrtimer and could also take ktime argument.

bye, Roman