From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ninad Palsule <ninad@linux.ibm.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
eajames@linux.ibm.com, jdelvare@suse.com, linux@roeck-us.net,
corbet@lwn.net, joel@jms.id.au, andrew@codeconstruct.com.au,
Delphine_CC_Chiu@Wiwynn.com, broonie@kernel.org,
peteryin.openbmc@gmail.com, noahwang.wang@outlook.com,
naresh.solanki@9elements.com, lukas@wunner.de,
jbrunet@baylibre.com, patrick.rudolph@9elements.com,
gregkh@linuxfoundation.org, peterz@infradead.org,
pbiel7@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-i2c@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 3/4] dt-bindings: hwmon: intel,crps185: Add to trivial
Date: Tue, 17 Dec 2024 06:49:45 +0100 [thread overview]
Message-ID: <21008f97-d0bd-45bf-8e10-9ec2539ed858@kernel.org> (raw)
In-Reply-To: <20241217022046.113830-4-ninad@linux.ibm.com>
On 17/12/2024 03:20, Ninad Palsule wrote:
> Add INTEL Common Redundant Power Supply Versions crps185 bindings as
> trivial. It is trivial because only compatibility string is required in
> the device tree to load this driver.
That's incorrect reason. You should describe the hardware, e.g. the
hardware does not have any resources, like clocks or supplies.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-17 5:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 2:20 [PATCH v3 0/4] Add support for Intel CRPS PSU Ninad Palsule
2024-12-17 2:20 ` [PATCH v3 1/4] hwmon: (pmbus/core) Add PMBUS_REVISION in debugfs Ninad Palsule
2024-12-17 2:20 ` [PATCH v3 2/4] hwmon: (pmbus/crps) Add Intel CRPS185 power supply Ninad Palsule
2024-12-17 2:20 ` [PATCH v3 3/4] dt-bindings: hwmon: intel,crps185: Add to trivial Ninad Palsule
2024-12-17 5:49 ` Krzysztof Kozlowski [this message]
2024-12-17 2:20 ` [PATCH v3 4/4] ARM: dts: aspeed: system1: Use crps PSU driver Ninad Palsule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21008f97-d0bd-45bf-8e10-9ec2539ed858@kernel.org \
--to=krzk@kernel.org \
--cc=Delphine_CC_Chiu@Wiwynn.com \
--cc=andrew@codeconstruct.com.au \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukas@wunner.de \
--cc=naresh.solanki@9elements.com \
--cc=ninad@linux.ibm.com \
--cc=noahwang.wang@outlook.com \
--cc=patrick.rudolph@9elements.com \
--cc=pbiel7@gmail.com \
--cc=peteryin.openbmc@gmail.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox