From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC0AC761AF for ; Wed, 29 Mar 2023 19:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229524AbjC2TUr convert rfc822-to-8bit (ORCPT ); Wed, 29 Mar 2023 15:20:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbjC2TUo (ORCPT ); Wed, 29 Mar 2023 15:20:44 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34CBD4201; Wed, 29 Mar 2023 12:20:40 -0700 (PDT) Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1phbLK-0006eg-Uh; Wed, 29 Mar 2023 21:20:22 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Eric Biggers , christoph.muellner@vrull.eu Cc: palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, herbert@gondor.apana.org.au, davem@davemloft.net, conor.dooley@microchip.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v4 4/4] RISC-V: crypto: add accelerated GCM GHASH implementation Date: Wed, 29 Mar 2023 21:20:21 +0200 Message-ID: <2102949.OBFZWjSADL@diego> In-Reply-To: References: <20230329140642.2186644-1-heiko.stuebner@vrull.eu> <20230329140642.2186644-5-heiko.stuebner@vrull.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eric, Am Mittwoch, 29. März 2023, 20:37:16 CEST schrieb Eric Biggers: > Hi Heiko, > > On Wed, Mar 29, 2023 at 04:06:42PM +0200, Heiko Stuebner wrote: > > diff --git a/arch/riscv/crypto/ghash-riscv64-zbc.pl b/arch/riscv/crypto/ghash-riscv64-zbc.pl > > new file mode 100644 > > index 000000000000..691231ffa11c > > --- /dev/null > > +++ b/arch/riscv/crypto/ghash-riscv64-zbc.pl > > @@ -0,0 +1,400 @@ > > +#! /usr/bin/env perl > > +# Copyright 2022 The OpenSSL Project Authors. All Rights Reserved. > > +# > > +# Licensed under the Apache License 2.0 (the "License"). You may not use > > +# this file except in compliance with the License. You can obtain a copy > > +# in the file LICENSE in the source distribution or at > > +# https://www.openssl.org/source/license.html > > My understanding is that code that is licensed under (only) the Apache License > 2.0 cannot be included in GPLv2 programs such as the Linux kernel. Thanks a lot for pointing out that possible licensing issue. It seems I'm not touching enough non-GPL code most days to keep that in the front of my mind :-) . > Is this code written by Andy Polyakov? What's been done in the past for his > code is that he re-releases it in CRYPTOGAMS at > https://github.com/dot-asm/cryptogams with a Linux kernel compatible license. > The Linux kernel then takes the code from there instead of from OpenSSL. The git log for the original openssl ".pl" thankfully only contains @vrull.eu addresses, so getting this in a compatible license shouldn't be overly hard - I hope. Heiko